Repository navigation
Conversation
Fixes: nodejs#67648 Assisted-by: Claude Code Signed-off-by: Zelalem Habtamu <zelalemhab19@gmail.com>
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67651 +/- ##
=======================================
Coverage 90.72% 90.72%
=======================================
Files 801 801
Lines 280944 280910 -34
Branches 54264 54246 -18
=======================================
- Hits 254876 254854 -22
+ Misses 16255 16250 -5
+ Partials 9813 9806 -7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
os.getPriority(-0)andos.setPriority(-0)abort the process becausevalidateInt32()accepts negative zero, but V8'sValue::IsInt32()returnsfalsefor it, causing the nativeCHECKinsrc/node_os.ccto fail.This PR normalizes the PID and priority arguments using
| 0inlib/os.jsbefore passing them to the native binding, following the approach used in #65888 for thefsmodule.A new
test/parallel/test-os-negative-zero.jsregression test coversos.getPriority(-0),os.setPriority(-0), andos.setPriority(0, -0).Verification: Reproduced the crashes on Windows 11 using Node.js
v24.8.0andv28.0.0-nightly20261119cdd06876da. I haven't built Node.js locally, so the fix will rely on CI for build and test verification.Fixes: #67648
AI disclosure: I used AI (Claude Code) to help identify the bug and draft the fix. I reviewed the changes, investigated the root cause, and independently reproduced and verified the issue.