Repository navigation
Conversation
`MockTimers#reset()` emptied the execution queue but left `priorityQueuePosition` set on the removed timers. Clearing such a stale timer later, for example from a previous test after the next test enabled its own mock timers, removed whichever timer sat at that position in the new queue, so that timer never fired. Fixes: nodejs#67593 Signed-off-by: sudoeren <hey@erencakar.com>
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MockTimers#reset()emptied the execution queue but leftpriorityQueuePositionset on the removed timers. Clearing such a stale timer later (for example a timer from a previous test, cleared after the next test enabled its own mock timers) removed whichever timer sat at that position in the new queue, so that timer never fired.reset()now clears the position of each timer it removes, so#clearTimer()treats them as no longer queued.Two tests are added: one for a timer cleared after
reset()on the same instance, and one for a timer from anotherMockTrackerinstance (the case in the issue). Both fail without the change.Fixes: #67593