Skip to content

tools: apply http lint rule to lib/internal/http - #67529

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Ethan-Arrowood:lint-internal-http
Nov 18, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Ethan-Arrowood:lint-internal-http

Conversation

@Ethan-Arrowood

@Ethan-Arrowood Ethan-Arrowood commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The lib/_http_*.js files moved to lib/internal/http/ recently. But the ESLint config still only listed the old paths. The moved files lost the "Do not use prototype primordials in this file" check that other HTTP hot paths have.

This change adds lib/internal/http/*.js to that rule list. The files already comply so no other changes are needed.

Refs: #58535

AI-assisted (Claude Opus 5.5, my setup). The words are my own, per the Human Voice policy.

The `lib/_http_*.js` files moved to `lib/internal/http/` recently.
But the ESLint config still only listed the old paths. The moved
files lost the "Do not use prototype primordials in this file"
check that other HTTP hot paths have.

This change adds `lib/internal/http/*.js` to that rule list. The
files already comply so no other changes are needed.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 16, 2026
@Ethan-Arrowood Ethan-Arrowood added tools Issues and PRs related to the tools directory. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

@Ethan-Arrowood Ethan-Arrowood added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 17, 2026
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Nov 17, 2026
@aduh95 aduh95 removed the dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. label Nov 18, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 0f2c061 into nodejs:main Nov 18, 2026
80 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 0f2c061

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 18, 2026
aduh95 pushed a commit that referenced this pull request Nov 19, 2026
The `lib/_http_*.js` files moved to `lib/internal/http/` recently.
But the ESLint config still only listed the old paths. The moved
files lost the "Do not use prototype primordials in this file"
check that other HTTP hot paths have.

This change adds `lib/internal/http/*.js` to that rule list. The
files already comply so no other changes are needed.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: #67529
Refs: #58535
Reviewed-By: Efe Karasakal <hi@efe.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants