Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/internal/fs/promises.js
Original file line number Diff line number Diff line change
Expand Up @@ -1218,8 +1218,12 @@ function rejectWithReason(signal, reject) {
};
}

async function raceWithSignal(opPromise, signal) {
function raceWithSignal(opPromise, signal) {
if (!signal) return opPromise;
return raceWithAbortSignal(opPromise, signal);
}

async function raceWithAbortSignal(opPromise, signal) {
const { promise: abortPromise, reject } = PromiseWithResolvers();
// eslint-disable-next-line no-unused-vars
using _ = EventEmitter.addAbortListener(signal,
Expand Down
4 changes: 3 additions & 1 deletion test/parallel/test-permission-fs-promises-stack-trace.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,21 @@ const { status, stderr } = spawnSync(
'-e',
`
const assert = require('assert');
const { readFile, writeFile, appendFile } = require('fs/promises');
const { readFile, writeFile, appendFile, stat } = require('fs/promises');
const target = ${JSON.stringify(tmpdir.resolve('file'))};

function readCaller() { return readFile(target); }
function writeCaller() { return writeFile(target, 'data'); }
function appendCaller() { return appendFile(target, 'data'); }
async function awaitAppendCaller() { await appendFile(target, 'data'); }
async function awaitStatCaller() { await stat(target); }

const cases = [
[readCaller, /at readCaller /],
[writeCaller, /at writeCaller /],
[appendCaller, /at appendCaller /],
[awaitAppendCaller, /at awaitAppendCaller /],
[awaitStatCaller, /at async awaitStatCaller /],
];
let checked = 0;
for (const [caller, stack] of cases) {
Expand Down
Loading