Repository navigation
Conversation
Collaborator
|
Review requested:
|
jasnell
commented
Nov 15, 2026
panva
approved these changes
Nov 15, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67493 +/- ##
==========================================
+ Coverage 90.72% 90.73% +0.01%
==========================================
Files 801 801
Lines 280889 280869 -20
Branches 54240 54243 +3
==========================================
+ Hits 254829 254842 +13
+ Misses 16245 16207 -38
- Partials 9815 9820 +5
🚀 New features to boost your workflow:
|
Collaborator
pimterry
approved these changes
Nov 15, 2026
Contributor
|
This pull request has conflicts with its base branch, removing the |
tniessen
approved these changes
Nov 16, 2026
AugustinMauroy
approved these changes
Nov 16, 2026
This comment was marked as resolved.
This comment was marked as resolved.
jasnell
force-pushed
the
crypto-eol-dep0031
branch
2 times, most recently
from
November 18, 2026 11:58
470f026 to
351d207
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Remove ecdh.setPublicKey(). ECDH only requires a private key and the other party's public key to compute a shared secret, and ecdh.setPrivateKey() already derives and sets the associated public key. The native ECDH setPublicKey binding is removed as well. diffieHellman.setPublicKey() is unaffected. This has been a runtime deprecation since v25.0.0 and a documentation-only deprecation since v5.2.0. Refs: nodejs#58620 Refs: nodejs#3511 Assisted-by: Claude Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
crypto-eol-dep0031
branch
from
November 20, 2026 06:42
351d207 to
7448ea2
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove ecdh.setPublicKey(). ECDH only requires a private key and the other party's public key to compute a shared secret, and ecdh.setPrivateKey() already derives and sets the associated public key. The native ECDH setPublicKey binding is removed as well.
diffieHellman.setPublicKey() is unaffected.
This has been a runtime deprecation since v25.0.0 and a documentation-only deprecation since v5.2.0.
Refs: #58620
Refs: #3511