Repository navigation
tools: add a workflow to send reminder about v8 backports - #67436
Open
joyeecheung wants to merge 1 commit into
Open
joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
This workflow detects whether the PR is a V8 backport and remind the author to wait for the next V8 major upgrade unless they can justify the fast-tracking following the documented criteria. It also checks if the v8_embedder_string is properly bumped. To avoid the noise, it also allows the use of a label `v8-backport-to-main` added at PR open time to surpress the check. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Member
Author
|
cc @nodejs/tsc @nodejs/v8-update |
Member
Author
|
I created v8-backport-to-main |
legendecas
reviewed
Nov 12, 2026
legendecas
left a comment
legendecas
left a comment
Member
There was a problem hiding this comment.
is v8-backport-to-main checked any where?
legendecas
reviewed
Nov 12, 2026
| MESSAGE: |- | ||
| This pull request changes `deps/v8` on the `main` branch without updating the V8 version, so it looks like a backport of individual V8 patches. | ||
| As a general rule, do not backport individual V8 patches to the Node.js `main` branch. Wait for them to be included in a V8 major version update instead. An individual V8 patch adds up audit cost and further delays the pending V8 update. |
Member
There was a problem hiding this comment.
Might be worth linking to https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md#backporting-patches-to-main so no need to repeat the policies and criteria.
Member
Author
There was a problem hiding this comment.
I think it would be more straightforward for newcomers if we just explain directly in the message. There's already also a link to the docs below (L59)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow detects whether the PR is a V8 backport and remind the author to wait for the next V8 major upgrade unless they can justify the fast-tracking following the documented criteria. It also checks if the v8_embedder_string is properly bumped. To avoid the noise, it also allows the use of a label
v8-backport-to-mainadded at PR open time to surpress the check.Fixes: #66393
Refs: #66710