Repository navigation
Conversation
The per-request timer can fire before the first response completes on a slow worker, before the test reaches the socket-reuse regression. Limit the keep-alive agent to one socket and send exactly two requests. Check that double-ending the first response leaves the same socket able to drain the second response and that the client receives both bodies. The test runner bounds a response that never completes. Assisted-by: Codex Signed-off-by: Tamir Duberstein <tamird@gmail.com>
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67426 +/- ##
=======================================
Coverage 90.69% 90.70%
=======================================
Files 801 801
Lines 281875 281875
Branches 54317 54312 -5
=======================================
+ Hits 255652 255668 +16
- Misses 16348 16349 +1
+ Partials 9875 9858 -17 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-request timer can fire before the first response completes on a slow worker, before the test reaches the socket-reuse regression.
Limit the keep-alive agent to one socket and send exactly two requests. Check that double-ending the first response leaves the same socket able to drain the second response and that the client receives both bodies. The test runner bounds a response that never completes.
Assisted-by: Codex