Repository navigation
repl: redraw highlighted input once per chunk - #67422
Open
maxhfisher wants to merge 1 commit into
Open
maxhfisher wants to merge 1 commit into
maxhfisher wants to merge 1 commit into
Conversation
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
nodejs-github-bot
added
needs-ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67422 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.02%
==========================================
Files 798 801 +3
Lines 280074 281922 +1848
Branches 53876 54323 +447
==========================================
+ Hits 254101 255737 +1636
- Misses 16272 16309 +37
- Partials 9701 9876 +175
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended as a fix for #67301. When text is pasted into the REPL, the terminal provides it in chunks, but
readlineinterprets and redraws the entire input for each character when syntax highlighting is enabled (#64591). When the pasted text is large, this makes the REPL feel noticeably slow.This changes
readlineto only redraw when a pasted chunk has been processed or if there is a character in the text that requires the screen to be up to date (such as a return or backspace). This reduces the number of full redraws and output as shown in the table below. However, the total number of bytes written to the terminal still grows quadratically with the number of lines. This only improves performance by a constant multiple for multi-line pastes.While working on this I noticed a separate bug (#67423 (comment)) on
mainwhich wasn't back-ported to v26 that causes large multi-line pastes to be truncated. To test this fix, you'll need to build it on top of v26.