Skip to content

test: preserve tick processor flags on retry - #67411

Open
tamird wants to merge 1 commit into
nodejs:mainfrom
tamird:test-tick-processor-retry-flags
Open

tamird wants to merge 1 commit into
nodejs:mainfrom
tamird:test-tick-processor-retry-flags

Conversation

@tamird

@tamird tamird commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

test-tick-processor-preprocess-flag expects JSON from --prof-process --preprocess. If its first profile does not match, the retry drops --preprocess and gets a text report. No later report can match the opening brace, so the test keeps retrying.

Pass the original flags on each attempt.

Assisted-by: Codex

test-tick-processor-preprocess-flag expects JSON from --prof-process
--preprocess. If its first profile does not match, the retry drops
--preprocess and gets a text report. No later report can match the
opening brace, so the test keeps retrying.

Pass the original flags on each attempt.

Assisted-by: Codex
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants