Repository navigation
[v26.x] deps: V8: cherry-pick f331137d596 - #67261
Closed
miladfarca wants to merge 2 commits into
Closed
miladfarca wants to merge 2 commits into
miladfarca wants to merge 2 commits into
Conversation
A TransformStream write that parks on backpressure was resumed from the read that lifted the backpressure, so transform(), the writes queued behind it, and flush() ran in the reader's async context instead of the writer's. Capture the async context frame when the write parks and restore it while the continuation runs, matching the context the spec's [[backpressureChangePromise]] reaction had. Fixes: nodejs#66906 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#66907 Backport-PR-URL: nodejs#66915 Fixes: nodejs#66906 Refs: nodejs#66906 Refs: nodejs#66907 Reviewed-By: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
Contributor
Author
|
/cc @richardlau |
richardlau
approved these changes
Nov 5, 2026
Collaborator
Collaborator
Collaborator
Collaborator
|
Hey @miladfarca any chance when it'll be merge, I need to update the maintainer. |
Contributor
Author
|
@ADITI-MISHRA310 Sorry we will have to wait for it to be fully reviewed and tested by the CI. |
Member
|
It could be fast tracked to land on the staging branch but it won't go out until the next next non-security (i.e. not next week's) Node.js 26 release. |
aduh95
force-pushed
the
v26.x-staging
branch
2 times, most recently
from
November 13, 2026 08:03
c2060d3 to
e7c0957
Compare
Merged
aduh95
pushed a commit
that referenced
this pull request
Nov 17, 2026
Original commit message:
PPC: Fix safepoint record
This patch is needed after http://crrev.com/c/7899697 started failing
this test intermittently during GC on pntr compressed debug builds:
```
=== mjsunit/compiler/regress-crbug-1464516 ===
--- stderr ---
#
# Fatal error in ../../src/objects/tagged-impl.h, line 138
# Debug check failed: kCanBeWeak || (!IsSmi() == HAS_STRONG_HEAP_OBJECT_TAG(ptr_)).
```
PPC could emit a trampoline pool right after `MacroAssembler::Call`
returns which could make any subsequent `DefineSafepoint` calls
record the incorrect `pc_offset` as it then points to after the emitted pool.
This CL patches every "MacroAssembler::Call" site to record the pc_offset before the trampoline pool is emitted similar to how it's
done on riscv.
It's essentially porting the following changes to PPC:
f385232a87a46af77c97e9095c8a25e559c37ce7
2c6618f2d927a91dd54727abf096828521f7439f
Change-Id: I2095bce8b69b0c4f064117ed95ee2f3245436e62
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7918866
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Reviewed-by: John <junyan1@ibm.com>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Cr-Commit-Position: refs/heads/main@{#107921}
Refs: v8/v8@f331137
PR-URL: #67261
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Contributor
|
Landed in 190faa4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@f331137d596