Repository navigation
sea: mount the VFS at layer 0 and in workers - #67256
Open
avivkeller wants to merge 1 commit into
Open
avivkeller wants to merge 1 commit into
avivkeller wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
avivkeller
marked this pull request as ready for review
November 4, 2026 16:13
Signed-off-by: avivkeller <me@aviv.sh>
avivkeller
force-pushed
the
vfs-archive-fix
branch
from
November 4, 2026 16:13
ce26cb6 to
3aac2a3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67256 +/- ##
==========================================
- Coverage 90.68% 90.66% -0.02%
==========================================
Files 797 797
Lines 279045 279376 +331
Branches 53666 53747 +81
==========================================
+ Hits 253050 253303 +253
- Misses 16337 16359 +22
- Partials 9658 9714 +56
🚀 New features to boost your workflow:
|
avivkeller
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Member
|
There are conflicts :/ |
gurgunday
removed
the
author ready
Contributor
|
Looks like this raced with #67239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single executable application built with "useVfs" and "assets"
mounted its virtual file system at the next free layer, and only in
the main thread. A worker had no mount at all, so a path into it, such
as a bundled worker script, could not be loaded there. On Windows the
reserved root sits under \.\NUL, so the loader read the NUL device
and failed with an invalid package.json error.
Fixes: #67223
Assisted-by: A Closed Source Agent