Repository navigation
vfs: place value before done in iterator result - #67231
Closed
LiviaMedeiros wants to merge 1 commit into
Closed
LiviaMedeiros wants to merge 1 commit into
LiviaMedeiros wants to merge 1 commit into
Conversation
Signed-off-by: LiviaMedeiros <livia@cirno.name>
LiviaMedeiros
added
the
fast-track
Contributor
|
Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve. |
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Nov 3, 2026
richardlau
approved these changes
Nov 3, 2026
richardlau
added
the
request-ci
aduh95
removed
the
request-ci
Contributor
|
Landed in 3930128 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67231 +/- ##
==========================================
- Coverage 90.71% 90.69% -0.03%
==========================================
Files 797 797
Lines 278898 278898
Branches 53627 53625 -2
==========================================
- Hits 252997 252934 -63
- Misses 16256 16309 +53
- Partials 9645 9655 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes linting currently failing on main. The line was added in #66254 between creation and landing of #66837 which inverted the lint rule for property order.
Refs: #66837 (comment)
cc @bakkot @aduh95