Repository navigation
ffi: make Fast API functions collectable - #67177
Merged
Merged
Conversation
V8 strongly caches instantiations of low-serial FunctionTemplates, which pinned Fast API functions and, through them, their DynamicLibrary and trampoline. FunctionTemplate::New() has no opt-out, so add an ObjectTemplate property to make these templates uncacheable, then delete it from the new function. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
ffi
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67177 +/- ##
==========================================
- Coverage 90.68% 90.67% -0.02%
==========================================
Files 797 797
Lines 278790 278805 +15
Branches 53617 53617
==========================================
- Hits 252834 252815 -19
- Misses 16303 16349 +46
+ Partials 9653 9641 -12
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
Nov 1, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
author ready
Collaborator
|
Landed in 70074c6 |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
V8 strongly caches instantiations of low-serial FunctionTemplates, which pinned Fast API functions and, through them, their DynamicLibrary and trampoline. FunctionTemplate::New() has no opt-out, so add an ObjectTemplate property to make these templates uncacheable, then delete it from the new function. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5 PR-URL: #67177 Fixes: #67176 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #67176
V8 strongly caches instantiations of low-serial
FunctionTemplates, which pinned Fast API functions and, through them, theirDynamicLibraryand trampoline.FunctionTemplate::New()has no cache opt-out, so this adds anObjectTemplateproperty to make these templates uncacheable, then deletes it from the new function.Assisted-by: claude:opus-5.5