Repository navigation
src: do not enable the inspector during snapshot building - #67154
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67154 +/- ##
==========================================
- Coverage 90.68% 90.67% -0.02%
==========================================
Files 797 797
Lines 279367 279381 +14
Branches 53737 53741 +4
==========================================
- Hits 253344 253324 -20
- Misses 16319 16354 +35
+ Partials 9704 9703 -1
🚀 New features to boost your workflow:
|
legendecas
approved these changes
Oct 31, 2026
legendecas
left a comment
legendecas
left a comment
Member
There was a problem hiding this comment.
LGTM but linter is complaining.
joyeecheung
force-pushed
the
fix-snapshot-inspector
branch
from
November 2, 2026 17:14
b0271b9 to
7feef72
Compare
Member
Author
|
Force-pushed to sign it off and fixed the linter complaint. |
Collaborator
Collaborator
legendecas
added
the
author ready
legendecas
approved these changes
Nov 3, 2026
V8 no longer allows attaching a debuger or setting a debug context ID during snapshot building. Avoid enabling the inspector in this case, and reject the inspector options when the user-land --build-snapshot is used. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8679045 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
force-pushed
the
fix-snapshot-inspector
branch
from
November 4, 2026 16:14
d475908 to
e6e89f9
Compare
Member
Author
|
Not sure why linter is failing at |
Collaborator
Member
Author
|
CI is finally green. @legendecas can you take a look again? Also need another approval to land maybe @nodejs/build @nodejs/v8-update would be interested in taking a look.. |
richardlau
approved these changes
Nov 5, 2026
Member
|
Should this have semver/dont-land labels? |
legendecas
approved these changes
Nov 5, 2026
Member
Author
It's a very niche use case and I doubt this was actually even working before, even if people did manage to make it work somehow it's unlikely to be used in automated tests since it's for debugging the snapshot building process with the inspector. I think it should be safe to land in older versions. |
joyeecheung
added
the
commit-queue
Collaborator
|
Landed in 5e893ce |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
V8 no longer allows attaching a debuger or setting a debug context ID during snapshot building. Avoid enabling the inspector in this case, and reject the inspector options when the user-land --build-snapshot is used. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8679045 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #67154 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 no longer allows attaching a debuger or setting a debug context ID during snapshot building. Avoid enabling the inspector in this case, and reject the inspector options when the user-land --build-snapshot is used.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8679045