Skip to content

build: trigger devcontainer build from daily - #67153

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Ethan-Arrowood:devcontainer-dispatch
Nov 18, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Ethan-Arrowood:devcontainer-dispatch

Conversation

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor

Sends a node-daily event to the nodejs/devcontainer repo to trigger a new devcontainer build upon a successful daily build. It shares the specific associated commit so the exact devcontainer is built.

This will enable new devcontainers to be automatically generated every time the daily Node.js build workflow runs enabling more up-to-date devcontainer images.

Requires: nodejs/devcontainer#31

Assisted-by: Claude Code

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 31, 2026
@Ethan-Arrowood Ethan-Arrowood added tools Issues and PRs related to the tools directory. build Issues and PRs related to Node.js builds or CI infrastructure. and removed meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Oct 31, 2026
@Ethan-Arrowood Ethan-Arrowood changed the title tools: trigger devcontainer build from daily build: trigger devcontainer build from daily Oct 31, 2026
Sends a node-daily event to the nodejs/devcontainer repo to trigger
a new devcontainer build upon a successful daily build. It shares
the specific associated commit so the exact devcontainer is built.

Requires: nodejs/devcontainer#31

Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
@Ethan-Arrowood

Copy link
Copy Markdown
Contributor Author

On second thought I think build: is the better subsystem for this.

-f event_type=node-daily \
-f "client_payload[sha]=$GITHUB_SHA"
env:
GH_TOKEN: ${{ secrets.GH_USER_TOKEN }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this token has the needed access (I assume it does, but we should make sure

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make sure to double check before merging this.

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor Author

Since this only touches a github workflow do I need to do anything special for merging it? commit-queue? Or can I just press the button when i'm ready?

@Ethan-Arrowood Ethan-Arrowood added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 18, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 8e494d4 into nodejs:main Nov 18, 2026
16 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 8e494d4

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 18, 2026
aduh95 pushed a commit that referenced this pull request Nov 19, 2026
Sends a node-daily event to the nodejs/devcontainer repo to trigger
a new devcontainer build upon a successful daily build. It shares
the specific associated commit so the exact devcontainer is built.

Requires: nodejs/devcontainer#31

Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: #67153
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants