Repository navigation
build: trigger devcontainer build from daily - #67153
Merged
nodejs-github-bot merged 1 commit intoNov 18, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
Sends a node-daily event to the nodejs/devcontainer repo to trigger a new devcontainer build upon a successful daily build. It shares the specific associated commit so the exact devcontainer is built. Requires: nodejs/devcontainer#31 Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
Ethan-Arrowood
force-pushed
the
devcontainer-dispatch
branch
from
October 31, 2026 02:09
21259b0 to
e9225ca
Compare
Contributor
Author
|
On second thought I think |
avivkeller
reviewed
Nov 2, 2026
| -f event_type=node-daily \ | ||
| -f "client_payload[sha]=$GITHUB_SHA" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GH_USER_TOKEN }} |
Member
There was a problem hiding this comment.
Make sure this token has the needed access (I assume it does, but we should make sure
Contributor
Author
There was a problem hiding this comment.
I'll make sure to double check before merging this.
avivkeller
approved these changes
Nov 2, 2026
Contributor
Author
|
Since this only touches a github workflow do I need to do anything special for merging it? commit-queue? Or can I just press the button when i'm ready? |
3 of 9 tasks
bnb
approved these changes
Nov 17, 2026
Collaborator
|
Landed in 8e494d4 |
aduh95
pushed a commit
that referenced
this pull request
Nov 19, 2026
Sends a node-daily event to the nodejs/devcontainer repo to trigger a new devcontainer build upon a successful daily build. It shares the specific associated commit so the exact devcontainer is built. Requires: nodejs/devcontainer#31 Signed-off-by: Ethan Arrowood <ethan@arrowood.dev> PR-URL: #67153 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Tierney Cyren <hello@bnb.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sends a node-daily event to the nodejs/devcontainer repo to trigger a new devcontainer build upon a successful daily build. It shares the specific associated commit so the exact devcontainer is built.
This will enable new devcontainers to be automatically generated every time the daily Node.js build workflow runs enabling more up-to-date devcontainer images.
Requires: nodejs/devcontainer#31
Assisted-by: Claude Code