Repository navigation
test: convert for each to for of in test/parallel/test-net-server-close - #67127
Merged
nodejs-github-bot merged 1 commit intoNov 2, 2026
Merged
nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Ethan-Arrowood
added
the
code-and-learn
Signed-off-by: 11rls11 <raymundo.lopzantiago@outlook.com>
11rls11
force-pushed
the
for-each-to-for-of-in-test-net-server-close
branch
from
October 29, 2026 23:12
1ce28ac to
50d6c5f
Compare
Ethan-Arrowood
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67127 +/- ##
==========================================
- Coverage 90.67% 90.67% -0.01%
==========================================
Files 797 797
Lines 278791 278791
Branches 53616 53617 +1
==========================================
- Hits 252807 252782 -25
- Misses 16334 16375 +41
+ Partials 9650 9634 -16 🚀 New features to boost your workflow:
|
Ethan-Arrowood
added
the
commit-queue
nodejs-github-bot
added
the
lacks-second-approval
joyeecheung
approved these changes
Nov 2, 2026
Collaborator
|
Landed in cd3b484 |
nodejs-github-bot
removed
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
Signed-off-by: 11rls11 <raymundo.lopzantiago@outlook.com> PR-URL: #67127 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
forEach()tofor...ofintest/parallel/test-net-server-close.jsCore style prefers
for...ofover.forEach()since it gives cleaner stack traces when a test fails, it works with await, and it avoids allocating a callback per iteration.Verified with: