Repository navigation
quic: fix crypto error classification - #66968
Merged
nodejs-github-bot merged 2 commits intoOct 30, 2026
Merged
Conversation
Signed-off-by: Efe Karasakal <hi@efe.dev>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Signed-off-by: Efe Karasakal <hi@efe.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66968 +/- ##
==========================================
- Coverage 90.59% 90.58% -0.01%
==========================================
Files 797 797
Lines 278293 278295 +2
Branches 53520 53518 -2
==========================================
- Hits 252112 252105 -7
- Misses 16563 16567 +4
- Partials 9618 9623 +5
🚀 New features to boost your workflow:
|
pimterry
approved these changes
Oct 24, 2026
pimterry
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
pimterry
added
commit-queue
nodejs-github-bot
added
the
lacks-second-approval
Collaborator
|
Landed in cfea992 |
nodejs-github-bot
removed
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev> PR-URL: #66968 Reviewed-By: Tim Perry <pimterry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuicError::is_crypto_error()checked only whether the0x100bit was set, causing overlapping application codes such as HTTP/3H3_MISSING_SETTINGS(0x10a) to be mislabeled as TLS alerts.Require the transport namespace and the RFC-defined
0x100–0x1ffrange before decoding TLS alerts. This follows RFC 9000 §20.1 and RFC 9001 §4.8.Adds regression coverage, and some doc improvements.
AI assistance: Codex assisted with the source investigation, implementation, and test drafting. I reviewed the resulting changes and RFC references.