Repository navigation
quic: fix internal error code conversion - #66967
Merged
nodejs-github-bot merged 2 commits intoOct 30, 2026
Merged
Conversation
Signed-off-by: Efe Karasakal <hi@efe.dev>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66967 +/- ##
==========================================
- Coverage 90.59% 90.58% -0.01%
==========================================
Files 797 797
Lines 278293 278293
Branches 53520 53517 -3
==========================================
- Hits 252112 252089 -23
- Misses 16563 16572 +9
- Partials 9618 9632 +14 🚀 New features to boost your workflow:
|
pimterry
approved these changes
Oct 24, 2026
pimterry
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
pimterry
added
commit-queue
nodejs-github-bot
added
the
lacks-second-approval
Collaborator
|
Landed in aadb911 |
nodejs-github-bot
removed
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev> PR-URL: #66967 Reviewed-By: Tim Perry <pimterry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two internal failure paths passed error
NGTCP2_INTERNAL_ERRORwhere an ngtcp2 library error was expected, causing it to fall back toPROTOCOL_VIOLATION.Use
NGTCP2_ERR_INTERNALso these failures are correctly reported asINTERNAL_ERROR.