Repository navigation
build: separate host and target Rust artifacts in cross builds - #66823
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
inoway46
force-pushed
the
build-rust-cross-targets
branch
from
October 21, 2026 12:01
19c9345 to
5ff420e
Compare
inoway46
marked this pull request as ready for review
October 21, 2026 12:34
This comment was marked as resolved.
This comment was marked as resolved.
inoway46
force-pushed
the
build-rust-cross-targets
branch
from
October 22, 2026 02:13
5ff420e to
6555d9d
Compare
inoway46
marked this pull request as draft
November 1, 2026 09:08
inoway46
force-pushed
the
build-rust-cross-targets
branch
3 times, most recently
from
November 2, 2026 09:43
815dcae to
7378d07
Compare
inoway46
marked this pull request as ready for review
November 2, 2026 10:12
inoway46
force-pushed
the
build-rust-cross-targets
branch
2 times, most recently
from
November 6, 2026 06:54
6478586 to
07ea604
Compare
Capture the Rust target and host triples during configure for bundled Temporal cross builds. Use explicit Cargo targets and separate output directories so host and target archives do not share a build rule. If the triples cannot be determined, disable Temporal with a warning unless it was explicitly enabled. Fixes: nodejs#66897 Refs: nodejs#66803 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
inoway46
force-pushed
the
build-rust-cross-targets
branch
from
November 6, 2026 08:50
07ea604 to
d155703
Compare
Member
|
Triggering CI to verify cross compile: https://ci.nodejs.org/job/node-test-pull-request/78929/ |
Collaborator
legendecas
approved these changes
Nov 9, 2026
legendecas
added
build
Collaborator
|
Landed in eb3ae47 |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
Capture the Rust target and host triples during configure for bundled Temporal cross builds. Use explicit Cargo targets and separate output directories so host and target archives do not share a build rule. If the triples cannot be determined, disable Temporal with a warning unless it was explicitly enabled. Fixes: #66897 Refs: #66803 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com> PR-URL: #66823 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled Temporal cross builds use a single Rust archive path for both host and target tools, so neither toolset links a matching archive.
This passes explicit Rust target triples to Cargo and builds each toolset into its own output directory:
CARGO_BUILD_TARGET(or the existing macOS x64 default)rustc -vVhost triple, or itsi686counterpart for 32-bit host tools (CC_host="gcc -m32")If the triples cannot be determined, Temporal support is disabled with a warning, or configure fails when
--v8-enable-temporal-supportis passed.Verified with AArch64, RISC-V, and ARMv7 Make cross builds: the original failure reproduces before this change, and both archives link and run after it.
Fixes: #66897
Refs: #66803