Repository navigation
watch: track all dependencies of an owner - #66139
Merged
nodejs-github-bot merged 1 commit intoNov 6, 2026
Merged
Conversation
filterFile() reads #ownerDependencies with the dependency path, but writes the set back keyed by the owner, so each call starts a fresh set and overwrites the previous one. An owner keeps only the last dependency registered for it. unfilterFilesOwnedBy() walks that set to release an owner's dependencies, so every other one stays in #filteredFiles and #dependencyOwners. Under `node --test --watch` a restart re-reports the modules the test still loads, which hides it for those, but a dependency it stopped requiring is never reported again and keeps re-running the test. Read #ownerDependencies with the key it is written with, and collapse the repeated #dependencyOwners lookup in the loop, which now runs once per dependency rather than once per owner. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66139 +/- ##
=======================================
Coverage 90.28% 90.28%
=======================================
Files 790 790
Lines 271982 271985 +3
Branches 51915 51921 +6
=======================================
+ Hits 245546 245571 +25
+ Misses 16947 16901 -46
- Partials 9489 9513 +24
🚀 New features to boost your workflow:
|
Member
Author
|
@MoLow since this is in the |
MoLow
approved these changes
Oct 7, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Member
Author
|
@panva Could you resume the CI when you get a chance? Thanks! |
Collaborator
inoway46
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
inoway46
approved these changes
Nov 6, 2026
inoway46
added
the
commit-queue
Collaborator
|
Landed in 280798a |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
filterFile() reads #ownerDependencies with the dependency path, but writes the set back keyed by the owner, so each call starts a fresh set and overwrites the previous one. An owner keeps only the last dependency registered for it. unfilterFilesOwnedBy() walks that set to release an owner's dependencies, so every other one stays in #filteredFiles and #dependencyOwners. Under `node --test --watch` a restart re-reports the modules the test still loads, which hides it for those, but a dependency it stopped requiring is never reported again and keeps re-running the test. Read #ownerDependencies with the key it is written with, and collapse the repeated #dependencyOwners lookup in the loop, which now runs once per dependency rather than once per owner. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> PR-URL: #66139 Refs: #45214 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FilesWatcher#filterFile()reads#ownerDependencieswith the dependency path, but writes the set back keyed by the owner. As a result, each call starts a fresh set and overwrites the previous one, so an owner keeps only the last dependency registered for it.Each test child reports the modules it loads through
watch:require/watch:import, with onefilterFile()call per module. A test file with N dependencies therefore keeps 1 and loses N-1.unfilterFilesOwnedBy()walks that set to release an owner's dependencies, so the lost dependencies remain in#filteredFilesand#dependencyOwners. A restart re-reports the modules the test still loads, which hides the stale state for those modules, but a dependency it stopped requiring is never reported again and therefore never removed:The second restart should not happen:
dep1.jsis no longer a dependency of any test. Its stale entries otherwise remain for the lifetime of the process.The bug was introduced with #45214 (
97355c74e819), first released in v19.2.0 and later backported to v18.13.0.test-watch-file-shared-dependencydoes not catch it because it registers one dependency per owner, while this bug requires an owner with multiple dependencies.The diff also stores the
#dependencyOwnerslookup in a local while removing an owner's dependencies, avoiding repeated map lookups for each dependency.Refs: #45214