Skip to content

fs: remove permissions fallback - #65990

Open
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:fs-remove-perms-fallback
Open

avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:fs-remove-perms-fallback

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Now that the permissions system is multi-threaded (#65392), we can remove the single-threaded fallback for directory recursion

Signed-off-by: avivkeller <me@aviv.sh>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 11, 2026
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.01%. Comparing base (46bbfc4) to head (33fca90).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 91.89% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65990      +/-   ##
==========================================
+ Coverage   89.98%   90.01%   +0.03%     
==========================================
  Files         784      784              
  Lines      268361   268265      -96     
  Branches    51117    51115       -2     
==========================================
- Hits       241478   241473       -5     
+ Misses      17438    17339      -99     
- Partials     9445     9453       +8     
Files with missing lines Coverage Δ
lib/fs.js 98.36% <100.00%> (+1.04%) ⬆️
lib/internal/fs/promises.js 91.66% <ø> (+0.84%) ⬆️
lib/internal/fs/utils.js 98.25% <ø> (+1.96%) ⬆️
src/node_file.cc 75.66% <91.89%> (+0.12%) ⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller
avivkeller requested review from RafaelGSS and codebytere and removed request for codebytere September 15, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants