ffi: reject direct SharedArrayBuffer pointers - #65233
Open
trivikr wants to merge 2 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
ShogunPanda
approved these changes
Aug 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65233 +/- ##
==========================================
+ Coverage 90.31% 90.33% +0.02%
==========================================
Files 751 751
Lines 249840 249837 -3
Branches 47180 47180
==========================================
+ Hits 225645 225697 +52
+ Misses 15587 15522 -65
- Partials 8608 8618 +10
🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
marked this pull request as draft
August 12, 2026 17:19
This comment was marked as outdated.
This comment was marked as outdated.
Reject direct SharedArrayBuffer pointer arguments in the JavaScript wrapper and native fast-buffer helper. This keeps validation behavior consistent before and after optimization. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
trivikr
force-pushed
the
ffi-sab-pointer-arg
branch
from
August 13, 2026 23:43
fd31a82 to
2bc35e2
Compare
trivikr
marked this pull request as ready for review
August 13, 2026 23:44
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Member
Author
|
@ShogunPanda Can you provide your approval again? I fixed an issue in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65232
Reject direct SharedArrayBuffer pointer arguments in the JavaScript wrapper and native fast-buffer helper. This keeps validation behavior consistent before and after optimization.
Assisted-by: codex:gpt-5.6-sol