src: avoid redundant DataPointer reallocations#64552
Merged
Merged
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
Collaborator
jasnell
approved these changes
Jul 19, 2026
panva
added
the
author ready
anonrig
approved these changes
Jul 21, 2026
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 0b7aa61 |
aduh95
pushed a commit
to panva/node
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataPointer::resize()checked for an unchanged size only afterrelease()had reset the stored length to zero. As a result, every non-empty resize calledOPENSSL_realloc(), even when the allocation was already the right size.Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.
Keep the explicit zero-length path to preserve successful empty crypto outputs.