dgram: add synchronous Socket connectSync()#63932
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dgram
guybedford
force-pushed
the
dgram-connect-sync
branch
2 times, most recently
from
cc1f517 to
9de034a
Compare
Signed-off-by: Guy Bedford <guybedford@gmail.com>
guybedford
force-pushed
the
dgram-connect-sync
branch
from
9de034a to
c360339
Compare
github-actions
Bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Jun 17, 2026
Collaborator
guybedford
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in eea8d72 |
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Guy Bedford <guybedford@gmail.com> PR-URL: #63932 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guybedford
added a commit
to guybedford/emscripten
that referenced
this pull request
Jun 23, 2026
This adds a new `-sNODERAWSOCKETS` setting that for supporting direct full sockets on Node.js via the `node:net` for TCP and `node:dgram` for UDP modules, without needing `ws`, an external proxy process, or pthreads.
* Full support for both outgoing and incoming TCP, using the `node:net` APIs.
* Full support for UDP using the `node:dgram` APIs
* Support for threading, with tests
* Support for IPV6
To support these embeddings without JSPI being mandatory requires using `process.binding('tcp_wrap')` and `process.binding('udp_wrap')` in Node.js, which are used here to support older versions of Node.js.
Further, to avoid having to rely on private APIs in modern Node.js I actually implemented upstream Node.js PRs to make public API surface area available for the full embedding in the following:
* nodejs/node#63838
* nodejs/node#63932
* nodejs/node#63951
* nodejs/node#63825
Then this PR conditionally checks these features and uses the public APIs as defined by them when it is able to, falling back to `tcp_wrap` and `udp_wrap` only when not supported. While Node.js with these features has not yet been released, as soon as all three have landed, we can rely on this surface area for modern 26+ versions of Node.js compat.
guybedford
added a commit
to guybedford/emscripten
that referenced
this pull request
Jun 23, 2026
This adds a new `-sNODERAWSOCKETS` setting that for supporting direct full sockets on Node.js via the `node:net` for TCP and `node:dgram` for UDP modules, without needing `ws`, an external proxy process, or pthreads.
* Full support for both outgoing and incoming TCP, using the `node:net` APIs.
* Full support for UDP using the `node:dgram` APIs
* Support for threading, with tests
* Support for IPV6
To support these embeddings without JSPI being mandatory requires using `process.binding('tcp_wrap')` and `process.binding('udp_wrap')` in Node.js, which are used here to support older versions of Node.js.
Further, to avoid having to rely on private APIs in modern Node.js I actually implemented upstream Node.js PRs to make public API surface area available for the full embedding in the following:
* nodejs/node#63838
* nodejs/node#63932
* nodejs/node#63951
* nodejs/node#63825
Then this PR conditionally checks these features and uses the public APIs as defined by them when it is able to, falling back to `tcp_wrap` and `udp_wrap` only when not supported. While Node.js with these features has not yet been released, as soon as all three have landed, we can rely on this surface area for modern 26+ versions of Node.js compat.
guybedford
added a commit
to guybedford/emscripten
that referenced
this pull request
Jun 23, 2026
This adds a new `-sNODERAWSOCKETS` setting that for supporting direct full sockets on Node.js via the `node:net` for TCP and `node:dgram` for UDP modules, without needing `ws`, an external proxy process, or pthreads.
* Full support for both outgoing and incoming TCP, using the `node:net` APIs.
* Full support for UDP using the `node:dgram` APIs
* Support for threading, with tests
* Support for IPV6
To support these embeddings without JSPI being mandatory requires using `process.binding('tcp_wrap')` and `process.binding('udp_wrap')` in Node.js, which are used here to support older versions of Node.js.
Further, to avoid having to rely on private APIs in modern Node.js I actually implemented upstream Node.js PRs to make public API surface area available for the full embedding in the following:
* nodejs/node#63838
* nodejs/node#63932
* nodejs/node#63951
* nodejs/node#63825
Then this PR conditionally checks these features and uses the public APIs as defined by them when it is able to, falling back to `tcp_wrap` and `udp_wrap` only when not supported. While Node.js with these features has not yet been released, as soon as all three have landed, we can rely on this surface area for modern 26+ versions of Node.js compat.
guybedford
added a commit
to guybedford/emscripten
that referenced
this pull request
Jun 23, 2026
This adds a new `-sNODERAWSOCKETS` setting that for supporting direct full sockets on Node.js via the `node:net` for TCP and `node:dgram` for UDP modules, without needing `ws`, an external proxy process, or pthreads.
* Full support for both outgoing and incoming TCP, using the `node:net` APIs.
* Full support for UDP using the `node:dgram` APIs
* Support for threading, with tests
* Support for IPV6
To support these embeddings without JSPI being mandatory requires using `process.binding('tcp_wrap')` and `process.binding('udp_wrap')` in Node.js, which are used here to support older versions of Node.js.
Further, to avoid having to rely on private APIs in modern Node.js I actually implemented upstream Node.js PRs to make public API surface area available for the full embedding in the following:
* nodejs/node#63838
* nodejs/node#63932
* nodejs/node#63951
* nodejs/node#63825
Then this PR conditionally checks these features and uses the public APIs as defined by them when it is able to, falling back to `tcp_wrap` and `udp_wrap` only when not supported. While Node.js with these features has not yet been released, as soon as all three have landed, we can rely on this surface area for modern 26+ versions of Node.js compat.
guybedford
added a commit
to guybedford/emscripten
that referenced
this pull request
Jun 23, 2026
This adds a new `-sNODERAWSOCKETS` setting that for supporting direct full sockets on Node.js via the `node:net` for TCP and `node:dgram` for UDP modules, without needing `ws`, an external proxy process, or pthreads.
* Full support for both outgoing and incoming TCP, using the `node:net` APIs.
* Full support for UDP using the `node:dgram` APIs
* Support for threading, with tests
* Support for IPV6
To support these embeddings without JSPI being mandatory requires using `process.binding('tcp_wrap')` and `process.binding('udp_wrap')` in Node.js, which are used here to support older versions of Node.js.
Further, to avoid having to rely on private APIs in modern Node.js I actually implemented upstream Node.js PRs to make public API surface area available for the full embedding in the following:
* nodejs/node#63838
* nodejs/node#63932
* nodejs/node#63951
* nodejs/node#63825
Then this PR conditionally checks these features and uses the public APIs as defined by them when it is able to, falling back to `tcp_wrap` and `udp_wrap` only when not supported. While Node.js with these features has not yet been released, as soon as all three have landed, we can rely on this surface area for modern 26+ versions of Node.js compat.
sbc100
pushed a commit
to emscripten-core/emscripten
that referenced
this pull request
Jun 24, 2026
This adds a new `-sNODERAWSOCKETS` setting that for supporting direct
full sockets on Node.js via the `node:net` for TCP and `node:dgram` for
UDP modules, without needing `ws`, an external proxy process, or
pthreads.
* Full support for both outgoing and incoming TCP, using the `node:net` APIs.
* Full support for UDP using the `node:dgram` APIs
* Support for threading, with tests
* Support for IPV6
To support these embeddings without JSPI being mandatory requires using
`process.binding('tcp_wrap')` and `process.binding('udp_wrap')` in
Node.js, which are used here to support older versions of Node.js.
Further, to avoid having to rely on private APIs in modern Node.js I
actually implemented upstream Node.js PRs to make public API surface
area available for the full embedding in the following:
* nodejs/node#63838
* nodejs/node#63932
* nodejs/node#63951
* nodejs/node#63825
Then this PR conditionally checks these features and uses the public
APIs as defined by them when it is able to, falling back to `tcp_wrap`
and `udp_wrap` only when not supported. While Node.js with these
features has not yet been released, as soon as all three have landed, we
can rely on this surface area for modern 26+ versions of Node.js compat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #63838 supporting a similar
connectSyncAPI forconnect(2)compat.In Node.js,
connect()uses positional arguments so that signature is matched for the sync case here too, unlike bind which accepts an options bag.Would be nice to include this with the bindSync release to ensure blanket compatibility.
//cc @jasnell @mcollina