repl: handle dot commands in multiline input#63889
Open
Diyoncrz18 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63864
This restores REPL dot-command handling when a command is entered from a TTY multiline continuation prompt.
Since TTY multiline input can arrive as one editable buffer like
function a() {\n.break, the previous command detection only checked the beginning of the full buffer and sent.break,.help, and.exitto JavaScript evaluation, producingUncaught SyntaxError: Unexpected token '.'.This change checks the newest physical line for registered REPL dot-commands in the TTY multiline case, keeps the preceding lines in the existing buffered-command path, and dispatches the dot-command through the existing REPL keyword handling.
Added regression coverage for:
.breakafter a recoverable multiline input.helpafter a recoverable multiline input.exitafter a recoverable multiline inputValidation:
node --check lib/repl.jsnode --check test/parallel/test-repl-multiline.jsgit diff --checkNote: I could not run
python tools/test.py test/parallel/test-repl-multiline.jslocally because this Windows checkout does not currently have a built Node binary.