util: fix -0 formatting when numericSeparator is enabled#63815
Closed
watilde wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Jun 9, 2026
ljharb
approved these changes
Jun 9, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
watilde
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63815 ✔ Done loading data for nodejs/node/pull/63815 ----------------------------------- PR info ------------------------------------ Title util: fix -0 formatting when numericSeparator is enabled (#63815) Author Daijiro Wachi <daijiro.wachi@gmail.com> (@watilde) Branch watilde:utils-fix -> nodejs:main Labels util, needs-ci Commits 1 - util: fix -0 formatting when numericSeparator is enabled Committers 1 - Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63815 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63815 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 09 Jun 2026 10:34:34 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/63815#pullrequestreview-4462290077 ✔ - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/63815#pullrequestreview-4462431386 ✘ GitHub CI failed with status: FAILURE ℹ Last Full PR CI on 2026-06-09T21:08:36Z: https://ci.nodejs.org/job/node-test-pull-request/74005/ - Querying data for job/node-test-pull-request/74005/ ✔ Build data downloaded - Querying failures of job/node-test-commit/88553/ ✔ Data downloaded ✘ 1 failure(s) on the last Jenkins CI run -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/27404596390 |
watilde
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
watilde
added a commit
that referenced
this pull request
Jun 15, 2026
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: #63815 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com>
Member
Author
|
Landed in 3ad2463 |
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: #63815 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.