Skip to content

deps: V8: backport c4d06ba586f33b8e5#63731

Open
Javonne-liu wants to merge 2 commits into
nodejs:mainfrom
Javonne-liu:fix-loong64-v8-opcode-209
Open

deps: V8: backport c4d06ba586f33b8e5#63731
Javonne-liu wants to merge 2 commits into
nodejs:mainfrom
Javonne-liu:fix-loong64-v8-opcode-209

Conversation

@Javonne-liu

@Javonne-liu Javonne-liu commented Jun 3, 2026 •
edited by Renegade334
Loading

Copy link
Copy Markdown
Contributor

Fixes: #63721

LoongArch64 CI is in a failed state (https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/1031/)

Always reproduces on LoongArch64 when executing the make out/doc/api/addons.html command.

Error Log:

[loongarch@90 node]$ make out/doc/api/addons.html
npm warn cli npm v11.16.0 does not support Node.js v27.0.0-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

added 369 packages, and audited 371 packages in 10s

142 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
mkdir -p out/doc/api
cp -r doc/api out/doc
AssembleArchSelect Unimplemented arch_opcode is : 209
UNIMPLEMENTED code_generator_loong64: AssembleArchSelect at line 4732


#
# Fatal error in , line 0
# unimplemented code
#
#
#
#FailureMessage Object: 0x7fffee5105c0
----- Native stack trace -----

 1: 0x5555571b1748  [/home/loongarch/liujh/node/node]
 2: 0x5555596649f0 V8_Fatal(char const*, ...) [/home/loongarch/liujh/node/node]
 3: 0x555559d00344  [/home/loongarch/liujh/node/node]
 4: 0x55555a075db0  [/home/loongarch/liujh/node/node]
 5: 0x55555a0776bc  [/home/loongarch/liujh/node/node]
 6: 0x555559813558  [/home/loongarch/liujh/node/node]
 7: 0x55555981efd8  [/home/loongarch/liujh/node/node]
 8: 0x55555979c5c4  [/home/loongarch/liujh/node/node]
 9: 0x55555803e38c  [/home/loongarch/liujh/node/node]
10: 0x55555804feb4  [/home/loongarch/liujh/node/node]
11: 0x555558051b00  [/home/loongarch/liujh/node/node]
12: 0x5555588ac85c  [/home/loongarch/liujh/node/node]
13: 0x5555571b2774  [/home/loongarch/liujh/node/node]
14: 0x7fffeff7a454  [/usr/lib64/libc.so.6]
15: 0x7fffeffff8cc  [/usr/lib64/libc.so.6]
make: *** [Makefile:886: out/doc/api/addons.html] Error 133

This has been fixed in the latest commit for the v8 loong64 architecture.
(Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7801520).
review.googlesource.com/c/v8/v8/+/7801520）。
I verified this locally by patching deps/v8. With the patch applied, make out/doc/api/addons.html runs successfully and the crash is completely resolved.

Origin commit message:

    [loong64][compiler] Extend Word64Select instruction functionality
    
    Change-Id: Iba762777642d2d2d3aa904f9afc1e9005139992e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7801520
    Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Commit-Queue: Liu Yu <liuyu@loongson.cn>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Liu Yu <liuyu@loongson.cn>
    Cr-Commit-Position: refs/heads/main@{#107619}

Refs: v8/v8@c4d06ba

@nodejs-github-bot

nodejs-github-bot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 3, 2026
@Javonne-liu
Javonne-liu force-pushed the fix-loong64-v8-opcode-209 branch 3 times, most recently from 3db807e to d51bfac Compare June 3, 2026 09:21
@Renegade334

Renegade334 commented Jun 8, 2026

Copy link
Copy Markdown
Member

V8 backports should follow the process detailed at https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md#backporting-with-git-node-recommended.

@Javonne-liu
Javonne-liu force-pushed the fix-loong64-v8-opcode-209 branch 2 times, most recently from dcf6977 to 136cba3 Compare June 10, 2026 10:01
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7220/

@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7220/

@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7220/

@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74032/

@Renegade334

Renegade334 commented Jun 10, 2026

Copy link
Copy Markdown
Member

We don't run V8 CI on loong64, but presumably make doc-only now runs OK for you on the PR branch?

@Renegade334 Renegade334 added the loong64 Issues and PRs related to the loong64 architecture. label Jun 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74045/

@Javonne-liu

Javonne-liu commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

We don't run V8 CI on loong64, but presumably make doc-only now runs OK for you on the PR branch?我们没有在 loong64 上运行 V8 CI，但想必现在在 PR 分支上 make doc-only 操作对您来说没问题了吧？

Thank you so much for the guidance and for reviewing this!@Renegade334
I have updated the PR following the recommended git node v8 backport process.
I manually verified it locally. The doc build (make out/doc/api/addons.html) runs smoothly and completes successfully on my loong64 machine.

[loongarch@90 node]$ make out/doc/api/addons.html
npm warn cli npm v11.16.0 does not support Node.js v27.0.0-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

added 369 packages, and audited 371 packages in 10s

142 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
mkdir -p out/doc/api
cp -r doc/api out/doc
[loongarch@90 node]$ make out/doc/api/addons.html
make: 'out/doc/api/addons.html' is up to date.

Really appreciate your patience and help!

@kuangxingye-design

This comment has been minimized.

Sign in to view
@Renegade334 Renegade334 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2026
@Javonne-liu Javonne-liu mentioned this pull request Jul 1, 2026
Closed
@sxa

sxa commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

LGTM. As mentioned in the other issue I did a test run on this PR and it no longer crashes in the doc target. Just one failure which I expect is unrelated:

15:48:26 Failed tests:
15:48:26 out/Release/node /home/iojs/build/workspace/node-test-commit-loongarch64/test/parallel/test-dns-lookupService-promises.js

So if this gets rebased then we can run another formal PR test and get this in.

@Javonne-liu
Javonne-liu force-pushed the fix-loong64-v8-opcode-209 branch from 136cba3 to 59b12cc Compare July 17, 2026 07:24
@Renegade334

Renegade334 commented Jul 17, 2026

Copy link
Copy Markdown
Member

Re-incremented the embedder string as this was clobbered in the rebase.

@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74864/

@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7267/

@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7267/

@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7267/

@Javonne-liu

Javonne-liu commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Re-incremented the embedder string as this was clobbered in the rebase.

Thank you so much for fixing that! I really appreciate the help.

@Javonne-liu

Javonne-liu commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author 
Run tar xzf tarballs/*.tar.gz -C "$RUNNER_TEMP"
  tar xzf tarballs/*.tar.gz -C "$RUNNER_TEMP"
  echo "TAR_DIR=$RUNNER_TEMP/$(basename tarballs/*.tar.gz .tar.gz)" >> "$GITHUB_ENV"
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    FLAKY_TESTS: keep_retrying
tar (child): tarballs/node-v[2](https://github.com/nodejs/node/actions/runs/29571139500/job/87867173277?pr=63731#step:3:2)7.0.0-nightly2026-07-175f188af1ad-slim.tar.gz: Cannot read: Is a directory
tar (child): At beginning of tape, quitting now
tar (child): Error is not recoverable: exiting now

gzip: stdin: unexpected end of file
tar: Child returned status 2
tar: Error is not recoverable: exiting now
Error: Process completed with exit code 2.

Does this look like a CI issue? I was wondering what causes it to fail with the 'Is a directory' error here.

@Renegade334

Renegade334 commented Jul 20, 2026

Copy link
Copy Markdown
Member

It's not an issue with this PR, but it will need to be sorted before this is merged. Sorry for the delays.

@Javonne-liu

Javonne-liu commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

It's not an issue with this PR, but it will need to be sorted before this is merged. Sorry for the delays.

I noticed on another PR that the CI issue seems to have been resolved and merged in #64633. Could you please help re-trigger the CI for this PR? Thank you so much for your help!

@Renegade334

Renegade334 commented Jul 21, 2026

Copy link
Copy Markdown
Member

You will need to rebase your PR branch.

@LiuYu3966 @Javonne-liu
deps: V8: backport c4d06ba586f3
552deec 
Original commit message:

    [loong64][compiler] Extend Word64Select instruction functionality

    Change-Id: Iba762777642d2d2d3aa904f9afc1e9005139992e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7801520
    Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Commit-Queue: Liu Yu <liuyu@loongson.cn>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Liu Yu <liuyu@loongson.cn>
    Cr-Commit-Position: refs/heads/main@{#107619}

Refs: v8/v8@c4d06ba
Co-authored-by: liujiahui <liujiahui@loongson.cn>
@Javonne-liu
Javonne-liu force-pushed the fix-loong64-v8-opcode-209 branch from db60603 to 552deec Compare July 21, 2026 06:21
@Javonne-liu Javonne-liu changed the title deps: backport V8 upstream fix for loong64 opcode 209 deps: V8: backport c4d06ba586f33b8e5 Jul 23, 2026
@Javonne-liu

Javonne-liu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

I rebased the branch recently to sync with the latest main, and I've also updated the PR title to align with how others format theirs. Everything looks green. Please let me know if anything else is needed from my side. 😊

@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7275/

@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75045/

@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7275/

@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7275/

@Renegade334
Renegade334 requested a review from targos July 23, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. loong64 Issues and PRs related to the loong64 architecture. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[LoongArch64] Execution crash: V8 Fatal error "AssembleArchSelect Unimplemented arch_opcode is : 209"

7 participants

@Javonne-liu @nodejs-github-bot @Renegade334 @kuangxingye-design @sxa @targos @LiuYu3966