stream: fix Writable.toWeb() desiredSize for non-object-mode#62986
Merged
nodejs-github-bot merged 1 commit intoJun 21, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62986 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01%
==========================================
Files 730 730
Lines 234209 234157 -52
Branches 43934 43906 -28
==========================================
- Hits 211558 211508 -50
- Misses 14372 14378 +6
+ Partials 8279 8271 -8
🚀 New features to boost your workflow:
|
Member
Technically, I think the Node.js side deals exclusively in |
Renegade334
approved these changes
Apr 27, 2026
Writable.toWeb() used a plain { highWaterMark } as the queuing
strategy for non-object-mode streams, which meant no size function
was provided. The WritableStream defaulted to counting each chunk
as size 1, so desiredSize was incorrect (e.g., a 3-byte Uint8Array
was counted as size 1 instead of 3).
Add a size() function to the strategy that mirrors how the Node.js
stream computes chunk length: byteLength for typed arrays, length
for strings/buffers, falling back to 1.
Fixes: nodejs#56269
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
fix-writable-toweb-desiredsize
branch
from
33b3fe0 to
088b5e2
Compare
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
added
the
author ready
trivikr
approved these changes
Jun 21, 2026
trivikr
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ca406b2 |
aduh95
pushed a commit
that referenced
this pull request
Jun 22, 2026
Writable.toWeb() used a plain { highWaterMark } as the queuing
strategy for non-object-mode streams, which meant no size function
was provided. The WritableStream defaulted to counting each chunk
as size 1, so desiredSize was incorrect (e.g., a 3-byte Uint8Array
was counted as size 1 instead of 3).
Add a size() function to the strategy that mirrors how the Node.js
stream computes chunk length: byteLength for typed arrays, length
for strings/buffers, falling back to 1.
Fixes: #56269
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #62986
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writable.toWeb() used a plain
{ highWaterMark }as the queuing strategy for non-object-mode streams, which meant nosizefunction was provided. The WritableStream defaulted to counting each chunk as size 1, sodesiredSizewas incorrect (e.g. a 3-byteUint8Arraywas counted as size 1 instead of 3).Add a
size()function to the strategy that mirrors how the Node.js stream computes chunk length:byteLengthfor typed arrays,lengthfor strings/buffers, falling back to 1.Fixes: #56269