meta: add DCO sign-off check to commit workflow#62473
Closed
jasnell wants to merge 1 commit intonodejs:mainfrom
Closed
meta: add DCO sign-off check to commit workflow#62473jasnell wants to merge 1 commit intonodejs:mainfrom
jasnell wants to merge 1 commit intonodejs:mainfrom
Conversation
All commits are technically supposed to be signed off with a DCO sign-off (using `Signed-off-by`) but we haven't enforced that. We really ought to be. Signed-off-by: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Member
|
This is best done via the DCO bot. |
Member
Author
|
Are you referring to https://github.com/apps/dco? If so, works for me.. I opened this solely as a nudge ;-) |
Member
|
That one! |
Member
Author
Member
Author
|
Reopening because there's some disagreement over whether we should use the bot @mcollina recommended. |
Contributor
|
https://github.com/nodejs/core-validate-commit is where you want to add that |
Contributor
|
Closing in favor of nodejs/core-validate-commit#141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All commits are technically supposed to be signed off with a DCO sign-off (using
Signed-off-by) but we haven't enforced that. We really ought to be.Signed-off-by: James M Snell jasnell@gmail.com