src: improve EC JWK import performance#62396
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 29, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
This was referenced Mar 22, 2026
jasnell
reviewed
Mar 22, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell
approved these changes
Mar 28, 2026
panva
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62396 ✔ Done loading data for nodejs/node/pull/62396 ----------------------------------- PR info ------------------------------------ Title src: improve EC JWK import performance (#62396) Author Filip Skokan <panva.ip@gmail.com> (@panva) Branch panva:improve-ec-jwk-import -> nodejs:main Labels author ready, needs-ci, dependencies Commits 1 - src: improve EC JWK import performance Committers 1 - Filip Skokan <panva.ip@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62396 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62396 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 22 Mar 2026 19:05:41 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/62396#pullrequestreview-4025611221 ✘ This PR needs to wait 46 more minutes to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-03-26T20:10:40Z: https://ci.nodejs.org/job/node-test-pull-request/72039/ - Querying data for job/node-test-pull-request/72039/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/23715821406 |
nodejs-github-bot
added
the
commit-queue-failed
panva
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f3633ef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All EC JWK import supported curves go through the optimized branch but I left the old one in just in case.