Skip to content

test: restraint version replacement pattern in snapshots#61748

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:test-version
Feb 9, 2026
Merged

test: restraint version replacement pattern in snapshots#61748
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:test-version

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Feb 9, 2026

In release workflows, the project root may contain the version of the binary. This restrains the replacement pattern of Node.js version to be more specific to the version in error outputs.

Refs: #61739 (comment)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (f0be1c0) to head (855e286).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61748   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         675      675           
  Lines      204529   204529           
  Branches    39315    39306    -9     
=======================================
+ Hits       183554   183556    +2     
- Misses      13246    13250    +4     
+ Partials     7729     7723    -6     

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Fast-track has been requested by @Renegade334. Please 👍 to approve.

@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2026
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 9, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2026
@nodejs-github-bot nodejs-github-bot merged commit a8479a2 into nodejs:main Feb 9, 2026
83 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a8479a2

@legendecas legendecas deleted the test-version branch February 9, 2026 13:10
aduh95 pushed a commit that referenced this pull request Feb 9, 2026
PR-URL: #61748
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants