repl: propagate setupHistory callback errors#61722
Closed
ThanhNguyxn wants to merge 1 commit intonodejs:mainfrom
Closed
repl: propagate setupHistory callback errors#61722ThanhNguyxn wants to merge 1 commit intonodejs:mainfrom
ThanhNguyxn wants to merge 1 commit intonodejs:mainfrom
Conversation
Errors thrown within the onReadyCallback passed to setupHistory() were being silently discarded when called from async contexts (event listeners and catch handlers). This fix wraps callback invocations in try-catch and uses process.nextTick to properly propagate errors. Fixes: nodejs#60837
Author
|
Closing as duplicate of #60903 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #60837
Errors thrown within the
onReadyCallbackpassed tosetupHistory()were being silently discarded when called from async contexts (event listeners and catch handlers).This was a regression introduced in #58225.
Changes
Wrapped callback invocations in try-catch blocks at two locations in
lib/internal/repl/history.js:'flushHistory'event listenerkHandleHistoryInitErrormethodUse
process.nextTick(() => { throw err; })to properly propagate errors to the event loop, ensuring callback errors are not silently swallowed.Root Cause Analysis
In
ReplHistory.initialize(), whenonReadyCallbackis invoked:Any errors thrown by the callback were being caught by the surrounding async context and silently discarded. The fix ensures these errors are re-thrown via
process.nextTickto properly surface them.Testing
Verified that callback errors are now properly propagated and cause uncaught exception handlers to fire as expected.