async_hooks: add using scopes to AsyncLocalStorage by Qard · Pull Request #61674 · nodejs/node

Qard · 2026-02-04T11:40:47Z

Adds support for using scope = storage.withScope(data) to do the equivalent of a storage.run(data, fn) with using syntax. This enables avoiding unnecessary closures.

cc @nodejs/diagnostics

Flarna · 2026-02-04T11:58:57Z

I guess this replaces #58104 right?

Qard · 2026-02-04T12:29:33Z

Ah, yes. Forgot that one existed. 😅

github-actions · 2026-02-04T16:05:03Z

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/21678728231

codecov · 2026-02-04T16:15:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (06a8240) to head (b055801).
⚠️ Report is 63 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61674   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files         676      677    +1     
  Lines      206578   206621   +43     
  Branches    39555    39567   +12     
=======================================
+ Hits       185267   185308   +41     
- Misses      13446    13447    +1     
- Partials     7865     7866    +1

Files with missing lines	Coverage Δ
...nternal/async_local_storage/async_context_frame.js	`100.00% <100.00%> (ø)`
lib/internal/async_local_storage/async_hooks.js	`98.03% <100.00%> (+0.08%)`	⬆️
lib/internal/async_local_storage/run_scope.js	`100.00% <100.00%> (ø)`

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

test/parallel/test-async-local-storage-run-scope.js

doc/api/async_context.md

Adds support for using scope = storage.withScope(data) to do the equivalent of a storage.run(data, fn) with using syntax. This enables avoiding unnecessary closures.

Qard · 2026-03-22T12:35:01Z

What are folks' opinions on public versus internal for this? The primary motivation for this is just to eliminate all the closure nesting in channel.runStores(...). We could opt for landing this undocumented, as an internal-only tool, if we're concerned about the possible safety issues of using ERM wrong.

nodejs-github-bot · 2026-03-26T03:38:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71969/

Flarna · 2026-03-26T07:56:23Z

I see no benefit with internal only. enterWith is exposed already which allows to leak context already now.

nodejs-github-bot · 2026-03-26T17:15:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72019/

nodejs-github-bot · 2026-03-28T20:03:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72156/

nodejs-github-bot · 2026-03-28T20:53:59Z

Landed in 5b6091c

Qard self-assigned this Feb 4, 2026

Qard added async_hooks Issues and PRs related to the async hooks subsystem. async_local_storage AsyncLocalStorage labels Feb 4, 2026

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 4, 2026

Qard force-pushed the als-run-scope branch 2 times, most recently from af2ad3e to d8e83aa Compare February 4, 2026 11:50

Qard force-pushed the als-run-scope branch from d8e83aa to cecbcb4 Compare February 4, 2026 12:27

Qard force-pushed the als-run-scope branch 2 times, most recently from 8b875c4 to 09cb6ad Compare February 4, 2026 14:14

sshiza-490 mentioned this pull request Feb 4, 2026

module: allow module.register from workers #53200

Closed

Qard mentioned this pull request Feb 4, 2026

diagnostics_channel: add BoundedChannel and scopes #61680

Open

Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 4, 2026

addaleax approved these changes Feb 6, 2026

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2026

This comment was marked as outdated.

Sign in to view

Flarna approved these changes Feb 6, 2026

View reviewed changes

Flarna added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Feb 6, 2026

legendecas reviewed Feb 6, 2026

View reviewed changes

doc/api/async_context.md Show resolved Hide resolved

async_hooks: add using scopes to AsyncLocalStorage

e9786c4

Adds support for using scope = storage.withScope(data) to do the equivalent of a storage.run(data, fn) with using syntax. This enables avoiding unnecessary closures.

Qard force-pushed the als-run-scope branch from de68dc5 to e9786c4 Compare March 17, 2026 16:40

fixup! async_hooks: add using scopes to AsyncLocalStorage

b055801

Qard requested review from Flarna, addaleax, bengl, jasnell and legendecas March 17, 2026 17:50

Qard mentioned this pull request Mar 20, 2026

Session Proposal: Observability infrastructure openjs-foundation/summit#485

Open

6 tasks

jasnell approved these changes Mar 22, 2026

View reviewed changes

legendecas approved these changes Mar 22, 2026

View reviewed changes

Qard added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 22, 2026

panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 25, 2026

Qard added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 25, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2026

Flarna approved these changes Mar 26, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

Qard added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Mar 28, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 28, 2026

nodejs-github-bot merged commit 5b6091c into nodejs:main Mar 28, 2026
78 of 81 checks passed

Qard deleted the als-run-scope branch March 28, 2026 20:56

Uh oh!

Conversation

Qard commented Feb 4, 2026

Uh oh!

Flarna commented Feb 4, 2026

Uh oh!

Qard commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

codecov bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Qard commented Mar 22, 2026

Uh oh!

nodejs-github-bot commented Mar 26, 2026

Uh oh!

Flarna commented Mar 26, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Mar 26, 2026

Uh oh!

nodejs-github-bot commented Mar 28, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Feb 4, 2026 •

edited

Loading