Skip to content

build,test: add tests for binary linked with shared libnode#61463

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
joyeecheung:fix-shared-pl-test
Jan 28, 2026
Merged

build,test: add tests for binary linked with shared libnode#61463
nodejs-github-bot merged 1 commit intonodejs:mainfrom
joyeecheung:fix-shared-pl-test

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 21, 2026

This adds tests to ensure the V8 parts (v8, libplatform, cppgc) in shared libnode works correctly.

Refs: #61144

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2026

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 21, 2026
@joyeecheung joyeecheung mentioned this pull request Jan 21, 2026
Closed
joyeecheung
joyeecheung commented Jan 21, 2026
View reviewed changes
node.gyp
'type': 'none',
}],
# Only test platforms known to work.
['OS not in "mac win linux"', {
Copy link
Member Author

@joyeecheung joyeecheung Jan 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested these platforms locally, in the CI this currently would only be exercised on Linux. For other platforms where people happen to build and use libnode, I guess there's no need to potentially break their test flow with this - if they care about this use case they can add the platform name into this mix to ensure it's tested in their workflow.

@jeroen
Copy link
Contributor

jeroen commented Jan 21, 2026

For reference this is needed to support embedding https://nodejs.org/api/embedding.html

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 21, 2026 •
edited
Loading

Yes, for testing the Node.js bits it will take more work. See the TODO I left in test/embedding/test-shared-embedding-v8.js (that thing currently fails, at least on macOS). This PR only tests the V8 bits.

@joyeecheung
build,test: add tests for binary linked with shared libnode
9da3c37 
This adds tests to ensure the V8 parts (v8, libplatform, cppgc)
in shared libnode works correctly.
@codecov
Copy link

codecov bot commented Jan 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (58f5da2) to head (9da3c37).
⚠️ Report is 86 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61463      +/-   ##
==========================================
+ Coverage   88.51%   88.52%   +0.01%     
==========================================
  Files         704      704              
  Lines      208884   208995     +111     
  Branches    40334    40344      +10     
==========================================
+ Hits       184889   185017     +128     
+ Misses      15966    15964       -2     
+ Partials     8029     8014      -15

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 22, 2026

cc @nodejs/build @nodejs/embedders

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70976/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 23, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70989/

aduh95
aduh95 approved these changes Jan 24, 2026
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a CI to run the tests?

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 24, 2026 •
edited
Loading

Do we have a CI to run the tests?

Yes, it's covered by https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_shared_x64/54421/

  ccache clang++-19 -o /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/shared_embedtest -pthread -rdynamic -fPIC -Wl,-rpath,\$ORIGIN -m64 -Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link=\/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/  -Wl,--start-group /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/shared_embedtest/test/embedding/shared_embedtest.o /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode.so.144 -latomic -Wl,--end-group

22:27:38 ok 4922 embedding/test-shared-embedding-v8
22:27:38   ---
22:27:38   duration_ms: 332.29600

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2026
@sxa sxa mentioned this pull request Jan 27, 2026
Merged
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026
@nodejs-github-bot nodejs-github-bot merged commit 983fd3f into nodejs:main Jan 28, 2026
66 of 67 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2026

Landed in 983fd3f

aduh95 pushed a commit that referenced this pull request Jan 28, 2026
@joyeecheung @aduh95
build,test: add tests for binary linked with shared libnode
150910d 
This adds tests to ensure the V8 parts (v8, libplatform, cppgc)
in shared libnode works correctly.

PR-URL: #61463
Refs: #61144
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actions github-actions bot mentioned this pull request Feb 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung @nodejs-github-bot @jeroen @richardlau @aduh95