tools: automate updates for test/fixtures/test426 #60978
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
This comment was marked as resolved.
This comment was marked as resolved.
aduh95
reviewed
Dec 11, 2025
Trott
force-pushed
the
udpate-test426
branch
from
024cd26 to
152749b
Compare
Trott
force-pushed
the
udpate-test426
branch
from
152749b to
1624e7f
Compare
aduh95
reviewed
Dec 14, 2025
aduh95
reviewed
Dec 14, 2025
| sed -i.bak "s#https://github.com/tc39/source-map-tests/commit/[0-9a-f]*#https://github.com/tc39/source-map-tests/commit/$SHA#" "$README" | ||
| rm "$README.bak" | ||
|
|
||
| echo "test426 fixtures updated to $SHA." |
Contributor
There was a problem hiding this comment.
Suggested change
| echo "test426 fixtures updated to $SHA." | |
| # The last line of the script should always print the new version, | |
| # as we need to add it to $GITHUB_ENV variable. | |
| echo "NEW_VERSION=$SHA" |
aduh95
reviewed
Dec 14, 2025
aduh95
reviewed
Dec 14, 2025
aduh95
reviewed
Dec 14, 2025
| @@ -0,0 +1,35 @@ | |||
| name: test426 fixtures update | |||
Contributor
There was a problem hiding this comment.
Should we move this to .github/workflows/tools.yml?
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Trott
added
the
commit-queue-squash
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Dec 14, 2025
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Dec 15, 2025
| TARBALL_URL=$(curl -fsIo /dev/null -w '%header{Location}' https://github.com/tc39/source-map-tests/archive/HEAD.tar.gz) | ||
| SHA=$(basename "$TARBALL_URL") | ||
|
|
||
| TMP_DIR="$(mktemp -d)" |
Contributor
There was a problem hiding this comment.
Suggested change
| TMP_DIR="$(mktemp -d)" | |
| CURRENT_SHA=$(sed -n 's#^.*https://github.com/tc39/source-map-tests/commit/\([0-9a-f]*\).*$#\1#p' "$README") | |
| if [ "$CURRENT_SHA" = "$SHA" ]; then | |
| echo "Already up-to-date" | |
| exit 0 | |
| fi |
aduh95
reviewed
Dec 15, 2025
Comment on lines
+18
to
+21
| rm -rf "$TMP_DIR" | ||
|
|
||
| TMP_FILE=$(mktemp) | ||
| sed "s#https://github.com/tc39/source-map-tests/commit/[0-9a-f]*#https://github.com/tc39/source-map-tests/commit/$SHA#" "$README" > "$TMP_FILE" |
Contributor
There was a problem hiding this comment.
Suggested change
| rm -rf "$TMP_DIR" | |
| TMP_FILE=$(mktemp) | |
| sed "s#https://github.com/tc39/source-map-tests/commit/[0-9a-f]*#https://github.com/tc39/source-map-tests/commit/$SHA#" "$README" > "$TMP_FILE" | |
| TMP_FILE=$(mktemp) | |
| sed "s/$CURRENT_SHA/$SHA/" "$README" > "$TMP_FILE" |
aduh95
reviewed
Dec 15, 2025
| @@ -0,0 +1,24 @@ | |||
| #!/bin/sh | |||
|
|
|||
| set -e | |||
Contributor
There was a problem hiding this comment.
We get a much more useful debug output with set -x
Suggested change
| set -e | |
| set -ex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.