This PR updates the documentation for fs.statfs to clarify that bsize is in bytes. Fixes #50749#59407
Closed
AtCloudDiwash wants to merge 1 commit into
Closed
This PR updates the documentation for fs.statfs to clarify that bsize is in bytes. Fixes #50749#59407AtCloudDiwash wants to merge 1 commit into
fs.statfs to clarify that bsize is in bytes. Fixes #50749#59407AtCloudDiwash wants to merge 1 commit into
Conversation
nodejs-github-bot
added
doc
Author
|
Hi @nodejs/fs, I'm checking back on this PR as it's been open for a few months. It's a small documentation fix to clarify the bsize unit in fs.statfs. Could a collaborator please review if this is correct and qualified to be merged? I’m happy to make any necessary updates if needed. Thank you! |
Contributor
|
Superseded by #62578 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the documentation for
fs.statfsto clarify thatbsizeis measured in bytes.Description
The current documentation for
fs.statfsdoes not explicitly state the unit forbsize. This change clarifies that the value returned is in bytes to improve developer clarity and prevent implementation errors.Fixes: #50749
Fixes: #59407