-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
doc(test): add missing passed and error on TextContext
#59322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(test): add missing passed and error on TextContext
#59322
Conversation
|
Review requested:
|
passed and error on TextContext
passed and error on TextContextpassed and error on TextContext
485f8ca to
24c4abc
Compare
24c4abc to
7ddb4dc
Compare
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising.
I wasn't aware of this functionality; I'll check the implementation this weekend to confirm.
…rties on TextContext
…r properties on TextContext
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
| ### `context.passed` {boolean} | ||
|
|
||
| <!-- YAML | ||
| added: v20.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the PR you linked
| added: v20.12.0 | |
| added: | |
| - v21.7.0 | |
| - v20.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aduh95 should we land it as is and have a follow-up PR? This seems to already improve the situation over what we have right now.
| ### `context.error` {Error|null} | ||
|
|
||
| <!-- YAML | ||
| added: v20.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here I reckon
| added: v20.12.0 | |
| added: | |
| - v21.7.0 | |
| - v20.12.0 |
| added: v20.12.0 | ||
| --> | ||
|
|
||
| The failure reason for the test/case; if anything other than an instance of `Error` was thrown, that will be wrapped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
| The failure reason for the test/case; if anything other than an instance of `Error` was thrown, that will be wrapped | |
| The failure reason for the test/case; if anything other than an instance of {Error} was thrown, that will be wrapped |
See #59321 and #51485 for implementation