test: reduce iteration count in test-child-process-stdout-flush-exit#58273
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 13, 2025
Merged
test: reduce iteration count in test-child-process-stdout-flush-exit#58273nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58273 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.01%
==========================================
Files 631 631
Lines 186652 186652
Branches 36660 36670 +10
==========================================
- Hits 168312 168299 -13
- Misses 11121 11127 +6
- Partials 7219 7226 +7 🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 11, 2025
addaleax
approved these changes
May 11, 2025
addaleax
added
author ready
jasnell
approved these changes
May 12, 2025
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f94d676 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58273 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
May 23, 2025
PR-URL: nodejs#58273 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit was added by @addaleax to fix the CI in #58124, opening it as a separate PR as the automation keeps removing it from the other PR. This should be landed manually so the commit authorship is credited to Anna and not myself.