[v20.x] tools: update sccache version to v0.10.0#57994
[v20.x] tools: update sccache version to v0.10.0#57994marco-ippolito wants to merge 2 commits intonodejs:v20.x-stagingfrom
Conversation
|
Review requested:
|
nodejs-github-bot
added
meta
No GHA tests were run on the release commit, only Jenkins. The failure on the previous commit were ignored I guess |
|
I dont see test-linux being run but I think its important to run it 🤔 |
It's not run because this PR hasn't changed any paths not ignored by: node/.github/workflows/test-linux.yml Lines 4 to 19 in 5357d0b |
Both commits are unrelated to test-linux though, why would you expect it to have any impact on it? |
|
I have the feeling the test is broken too due to the folder with weird chars tests being added, maybe I can run it manually ? |
|
Yeah test-linux is broken too, Ill fix the change that broke it |
marco-ippolito
force-pushed
the
fix-conflicts
branch
2 times, most recently
from
2a711ce to
766d237
Compare
|
I'm not sure why the test is broken on linux arm64, but its unrelated, can we backport this PR? At least it will allow other backports to run the tests |
|
@marco-ippolito if you remove 766d237 from this PR, you'll have a green CI and it can land immediately, I suggest you do that and take 766d237 to a separate PR |
|
I opened #58351 to address the linux failure |
marco-ippolito
force-pushed
the
fix-conflicts
branch
from
766d237 to
80a2ca7
Compare
PR-URL: #57994 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
PR-URL: #57994 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
|
Landed in debd3c2...7c449ed |
5 participants
The update in 29c0324 was overwritten by d45517c.
Also this line breaks the test 29c0324#diff-9e078b64804cbda5c87567835a5da2f1314788813ec5c5e9809a2f96519b9b01R99
not sure why it worked during the release 🤔
@nodejs/releasers