doc: add type stripping to ambassadors program#56598
Merged
nodejs-github-bot merged 3 commits intoJan 16, 2025
Merged
Conversation
Collaborator
|
Review requested:
|
marco-ippolito
force-pushed
the
add-ts-to-ambassadors
branch
from
838bc49 to
9665f8e
Compare
aduh95
reviewed
Jan 15, 2025
aduh95
reviewed
Jan 15, 2025
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
jasnell
approved these changes
Jan 15, 2025
UlisesGascon
approved these changes
Jan 15, 2025
legendecas
approved these changes
Jan 16, 2025
marco-ippolito
added
the
author ready
mcollina
approved these changes
Jan 16, 2025
mcollina
left a comment
mcollina
left a comment
Member
There was a problem hiding this comment.
lgtm
I think we should get a compatible tsconfig configuration published anyway and promoted.
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b3641fe |
This was referenced Jan 28, 2025
Merged
1 task
This was referenced Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding type stripping to the messages we would like ambassadors.
I rushed the goals, feel free to suggest refinements.
@nodejs/tsc for visibility