Repository navigation
Conversation
Collaborator
|
Review requested:
|
Member
Author
|
For those reviewing, please feel free to add other benefits of Node.js we should promote and/or volunteer as one of the people who can be contacted by the Ambassadors. |
jasnell
approved these changes
Nov 29, 2024
Member
|
how about these too:
|
aduh95
reviewed
Nov 30, 2024
UlisesGascon
approved these changes
Nov 30, 2024
Member
Author
|
@gireeshpunathil added. |
Member
Author
|
Will rebase once its ready to land. |
trivikr
reviewed
Dec 2, 2024
gireeshpunathil
approved these changes
Dec 3, 2024
marco-ippolito
approved these changes
Dec 3, 2024
Add an initial message to be promoted. Signed-off-by: Michael Dawson <midawson@redhat.com>
mhdawson
force-pushed
the
ambassador-message
branch
from
December 10, 2024 21:07
aa33af0 to
9969b11
Compare
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/56085 ✔ Done loading data for nodejs/node/pull/56085 ----------------------------------- PR info ------------------------------------ Title doc: add ambassador message - benefits of Node.js (#56085) Author Michael Dawson <midawson@redhat.com> (@mhdawson) Branch mhdawson:ambassador-message -> nodejs:main Labels doc Commits 1 - doc: add ambassador message - benefits of Node.js Committers 1 - Michael Dawson <midawson@redhat.com> PR-URL: https://github.com/nodejs/node/pull/56085 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56085 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: add ambassador message - benefits of Node.js ℹ This PR was created on Fri, 29 Nov 2024 19:57:19 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56085#pullrequestreview-2470504300 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56085#pullrequestreview-2470941987 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/56085#pullrequestreview-2474608608 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56085#pullrequestreview-2475311296 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12265571694 |
mhdawson
added a commit
that referenced
this pull request
Dec 10, 2024
Add an initial message to be promoted. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56085 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Member
Author
|
Landed in 142adef |
targos
pushed a commit
that referenced
this pull request
Dec 13, 2024
Add an initial message to be promoted. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56085 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an initial message to be promoted.