Skip to content

doc: add ambassador message - benefits of Node.js - #56085

Closed
mhdawson wants to merge 1 commit into
nodejs:mainfrom
mhdawson:ambassador-message
Closed

mhdawson wants to merge 1 commit into
nodejs:mainfrom
mhdawson:ambassador-message

Conversation

@mhdawson

Copy link
Copy Markdown
Member

Add an initial message to be promoted.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 29, 2024
@mhdawson

Copy link
Copy Markdown
Member Author

For those reviewing, please feel free to add other benefits of Node.js we should promote and/or volunteer as one of the people who can be contacted by the Ambassadors.

@gireeshpunathil

Copy link
Copy Markdown
Member

how about these too:

  • asynchronous non-blocking i/o architecture drives high transactional throughput, making it ideal for web workloads
  • single threaded programming model enables very low resource consumption, making it ideal for containerised workloads
  • highly vibrant ecosystem with enterprise support from many vendors

@mhdawson

mhdawson commented Dec 2, 2024

Copy link
Copy Markdown
Member Author

@gireeshpunathil added.

@mhdawson

mhdawson commented Dec 2, 2024

Copy link
Copy Markdown
Member Author

Will rebase once its ready to land.

Add an initial message to be promoted.

Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson mhdawson added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 10, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 10, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/56085
✔  Done loading data for nodejs/node/pull/56085
----------------------------------- PR info ------------------------------------
Title      doc: add ambassador message - benefits of Node.js (#56085)
Author     Michael Dawson <midawson@redhat.com> (@mhdawson)
Branch     mhdawson:ambassador-message -> nodejs:main
Labels     doc
Commits    1
 - doc: add ambassador message - benefits of Node.js
Committers 1
 - Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/56085
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56085
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: add ambassador message - benefits of Node.js
   ℹ  This PR was created on Fri, 29 Nov 2024 19:57:19 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56085#pullrequestreview-2470504300
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56085#pullrequestreview-2470941987
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/56085#pullrequestreview-2474608608
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56085#pullrequestreview-2475311296
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/12265571694

mhdawson added a commit that referenced this pull request Dec 10, 2024
Add an initial message to be promoted.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #56085
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@mhdawson

Copy link
Copy Markdown
Member Author

Landed in 142adef

@mhdawson mhdawson closed this Dec 10, 2024
targos pushed a commit that referenced this pull request Dec 13, 2024
Add an initial message to be promoted.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #56085
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants