test: move more zlib tests to node:test#54609
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 1, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54609 +/- ##
==========================================
- Coverage 87.34% 87.30% -0.04%
==========================================
Files 649 649
Lines 182562 182755 +193
Branches 35023 35044 +21
==========================================
+ Hits 159451 159561 +110
- Misses 16396 16465 +69
- Partials 6715 6729 +14 |
c1b0693 to
7631e70
Compare
atlowChemi
reviewed
Aug 29, 2024
atlowChemi
reviewed
Aug 29, 2024
bdd2e1e to
749198f
Compare
749198f to
abf4dcc
Compare
abf4dcc to
af7fd9a
Compare
jasnell
approved these changes
Aug 29, 2024
Collaborator
atlowChemi
approved these changes
Aug 29, 2024
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
|
Landed in 826b753 |
sendoru
pushed a commit
to sendoru/node
that referenced
this pull request
Sep 1, 2024
PR-URL: nodejs#54609 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54609 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54609 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54609 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving zlib tests to use
node:test