test: add coverage for webstorage quota#53964
Closed
jakecastelli wants to merge 2 commits intonodejs:mainfrom
Closed
test: add coverage for webstorage quota#53964jakecastelli wants to merge 2 commits intonodejs:mainfrom
jakecastelli wants to merge 2 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
jakecastelli
force-pushed
the
ref-53871-max-storage-quota
branch
from
7b54022 to
06067e3
Compare
jasnell
approved these changes
Jul 21, 2024
jakecastelli
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Edit: hmm actually - why it needs a rebase if it does not have merge conflict (it only adds a new test) 🤔 probably rebase failure was for something else, will pay more attention to the cause when I see it next time. After the rebase it did run ok though. |
jakecastelli
force-pushed
the
ref-53871-max-storage-quota
branch
from
06067e3 to
c44e668
Compare
Collaborator
Collaborator
Member
Author
|
Do you mind taking a look @cjihrig 🙏 |
cjihrig
approved these changes
Jul 28, 2024
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
This looks fine to me. I think it could be improved in a few ways:
- Remove the loops. Unless I'm missing something, it seems like extra work that makes the test harder to reason about.
- Perform the entire localStorage test in a single child process like the sessionStorage test.
- Since you're matching stderr, add something to the output so you can verify that the assertion came from the place you intended. In the sessionStorage test I don't think we can differentiate a failure in the loop vs the
sessionStorage.anythingline.
I think something like this would work:
const max = 10 * 1024 * 1024;
sessionStorage['i'.repeat(max / 2)] = '';
console.error('filled');
sessionStorage['x'] = '';
Member
Author
|
Thanks for the review 🙏
Done, I remembered I hit a limit error from V8 about string size being too big but I cannot reproduce it anymore.
Done
Good suggestion, done ✔️ |
github-actions
bot
removed
the
request-ci
Collaborator
JungMinu
approved these changes
Jul 29, 2024
jakecastelli
added
the
commit-queue-squash
cjihrig
approved these changes
Jul 31, 2024
jakecastelli
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/53964 ✔ Done loading data for nodejs/node/pull/53964 ----------------------------------- PR info ------------------------------------ Title test: add coverage for webstorage quota (#53964) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:ref-53871-max-storage-quota -> nodejs:main Labels test, author ready, needs-ci, commit-queue-squash Commits 2 - test: add coverage for webstorage quota - fixup! improve test Committers 1 - jakecastelli <jake.yuesong@gmail.com> PR-URL: https://github.com/nodejs/node/pull/53964 Refs: https://github.com/nodejs/node/issues/53871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53964 Refs: https://github.com/nodejs/node/issues/53871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 20 Jul 2024 04:20:43 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53964#pullrequestreview-2190383507 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/53964#pullrequestreview-2208922439 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/53964#pullrequestreview-2205194172 ✘ GitHub CI is still running ℹ Last Full PR CI on 2024-07-29T10:32:41Z: https://ci.nodejs.org/job/node-test-pull-request/60719/ - Querying data for job/node-test-pull-request/60719/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10207447292 |
jakecastelli
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/53964 ✔ Done loading data for nodejs/node/pull/53964 ----------------------------------- PR info ------------------------------------ Title test: add coverage for webstorage quota (#53964) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:ref-53871-max-storage-quota -> nodejs:main Labels test, author ready, needs-ci, commit-queue-squash Commits 2 - test: add coverage for webstorage quota - fixup! improve test Committers 1 - jakecastelli <jake.yuesong@gmail.com> PR-URL: https://github.com/nodejs/node/pull/53964 Refs: https://github.com/nodejs/node/issues/53871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53964 Refs: https://github.com/nodejs/node/issues/53871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 20 Jul 2024 04:20:43 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53964#pullrequestreview-2190383507 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/53964#pullrequestreview-2208922439 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/53964#pullrequestreview-2205194172 ✘ GitHub CI is still running ℹ Last Full PR CI on 2024-08-01T23:49:52Z: https://ci.nodejs.org/job/node-test-pull-request/60719/ - Querying data for job/node-test-pull-request/60719/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10214193300 |
marco-ippolito
approved these changes
Aug 2, 2024
jakecastelli
removed
the
commit-queue-failed
Member
Author
|
Landed in 0c1877a |
Merged
targos
added
the
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #53871