Skip to content

v8: move ToNamespacedPath to c++ #53655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jul 4, 2024
Merged

v8: move ToNamespacedPath to c++ #53655

nodejs-github-bot merged 1 commit into from
Jul 4, 2024

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jun 30, 2024

Moves toNamespacedPath call from JS to C++.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 30, 2024
@anonrig anonrig requested a review from jasnell July 1, 2024 14:43
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60064/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit 20fbfaf into nodejs:main Jul 4, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2024

Landed in 20fbfaf

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig @aduh95
v8: move ToNamespacedPath to c++
f204f3c 
PR-URL: #53655
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig @aduh95
v8: move ToNamespacedPath to c++
5aa2163 
PR-URL: #53655
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolito marco-ippolito added the backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@H4ad H4ad H4ad approved these changes

@targos targos Awaiting requested review from targos

@tniessen tniessen Awaiting requested review from tniessen

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig @nodejs-github-bot @jasnell @H4ad @marco-ippolito