test: refactor, add assertion to http-request-end #53411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Member
Author
|
Coverage Linux (without intl) / coverage-linux-without-intl failed?? 👀 |
Member
|
JS tests didn't run because of a flaky C++ test (#47427). I rerun the workflow. |
lpinca
approved these changes
Jun 12, 2024
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
jakecastelli
force-pushed
the
improve-http-request-end-test
branch
from
280fcaa to
4c75b9b
Compare
Member
Author
|
CI rerun failed again due to build failed, I think because it needs a rebase. I have just rebased, should be good now 🙏 |
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
|
Green CI 🎉 can this one land? |
H4ad
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/53411 ✔ Done loading data for nodejs/node/pull/53411 ----------------------------------- PR info ------------------------------------ Title test: refactor, add assertion to http-request-end (#53411) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:improve-http-request-end-test -> nodejs:main Labels test, needs-ci Commits 1 - test: refactor, add assertion to http-request-end Committers 1 - jakecastelli <959672929@qq.com> PR-URL: https://github.com/nodejs/node/pull/53411 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53411 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: refactor, add assertion to http-request-end ℹ This PR was created on Tue, 11 Jun 2024 03:27:24 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53411#pullrequestreview-2114185242 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-21T15:21:08Z: https://ci.nodejs.org/job/node-test-pull-request/59911/ - Querying data for job/node-test-pull-request/59911/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9648962891 |
Member
Author
|
commit queue failed, as it needs approval again, could someone take a look 👀 |
lpinca
approved these changes
Jun 26, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b40ff3a |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests with
./node test/parallel/test-http-request-end.jsand seeing200printed to the console. Replaced the log with assertion and addedmustCallto make the test more strict.