v8: fix template literal NULL pointer deref#534
Merged
Conversation
Contributor
|
You're sending the backport CL? LGTM |
Contributor
|
I thought dslomov was going to do it but maybe not |
Member
|
LGTM if it works |
Fixes a NULL pointer dereference with unterminated template literals. This is a back-port of commit v8/v8@02218ad from the V8 master branch, see https://code.google.com/p/v8/issues/detail?id=3820. PR-URL: nodejs#534 Reviewed-By: Caitlin Potter <caitpotter88@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
force-pushed
the
fix-v8-null-ptr-deref
branch
from
bbe16c0 to
803883b
Compare
Member
Author
|
@caitp I may have missed it but I didn't see any CRs targeted for 4.1. |
Contributor
|
yeah I haven't sent one... if you're going to do it you can go for it, otherwise I'll do that today |
Member
Author
|
@caitp I got stumped by https://code.google.com/p/v8/issues/detail?id=3835. The patch from this PR applies cleanly but I couldn't get the test suite to build because of that. |
Member
Author
|
dslomov filed one: https://codereview.chromium.org/861173005/ - lots of buildbot failures, though. |
This was referenced Apr 26, 2023
This was referenced Apr 27, 2023
This was referenced Jun 20, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a NULL pointer dereference with unterminated template literals.
This is a back-port of commit v8/v8@02218ad from the V8
master branch, see https://code.google.com/p/v8/issues/detail?id=3820.
R=@indutny @caitp
I'm going to send this upstream after
make x64.release.quickcheckcompletes...