Skip to content

test: replace .substr with .slice#53070

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:sub-substr
May 22, 2024
Merged

test: replace .substr with .slice#53070
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:sub-substr

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 20, 2024

String.prototype.substr is deprecated, and using it will raise an error when using ESLint 9+ (#52780).

@aduh95 @targos
test: replace .substr with .slice
88656b5 
`String.prototype.substr` is deprecated, and using it will raise an
error when using ESLint 9+.

Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 20, 2024
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. and removed test Issues and PRs related to the tests. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 20, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59311/

targos
targos approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not exactly ESLint 9 that introduces the error, but the migration to flat config.

juanarbol
juanarbol approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Just curiosity, why not substring?

@targos
Copy link
Member

targos commented May 21, 2024

I return the question: why do you think we should use substring?

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 21, 2024
@targos targos added the fast-track PRs that do not need to wait for 72 hours to land. label May 21, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2024

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 21, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2024

Commit Queue failed
- Loading data for nodejs/node/pull/53070
✔  Done loading data for nodejs/node/pull/53070
----------------------------------- PR info ------------------------------------
Title      test: replace `.substr` with `.slice` (#53070)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:sub-substr -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: replace `.substr` with `.slice`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/53070
Reviewed-By: Michaël Zasso 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53070
Reviewed-By: Michaël Zasso 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 20 May 2024 11:21:02 GMT
   ✔  Approvals: 7
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066181127
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066321383
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066494050
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066592235
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067271445
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067536710
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067888793
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 22 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-05-20T11:26:29Z: https://ci.nodejs.org/job/node-test-pull-request/59311/
- Querying data for job/node-test-pull-request/59311/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9174979544

@bnb bnb added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 21, 2024
@bnb
Copy link
Contributor

bnb commented May 21, 2024

requeued (?) since it was only missing a 👍🏻 on the fast track

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 21, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2024

Commit Queue failed
- Loading data for nodejs/node/pull/53070
✔  Done loading data for nodejs/node/pull/53070
----------------------------------- PR info ------------------------------------
Title      test: replace `.substr` with `.slice` (#53070)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:sub-substr -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: replace `.substr` with `.slice`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/53070
Reviewed-By: Michaël Zasso 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Moshe Atlow 
Reviewed-By: Tierney Cyren 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53070
Reviewed-By: Michaël Zasso 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Moshe Atlow 
Reviewed-By: Tierney Cyren 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 20 May 2024 11:21:02 GMT
   ✔  Approvals: 8
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066181127
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066321383
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066494050
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066592235
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067271445
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067536710
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067888793
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/53070#pullrequestreview-2069078323
   ℹ  This PR is being fast-tracked
   ✘  GitHub CI is still running
   ℹ  Last Full PR CI on 2024-05-21T12:51:22Z: https://ci.nodejs.org/job/node-test-pull-request/59311/
- Querying data for job/node-test-pull-request/59311/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9177998933

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4a54a80 into nodejs:main May 22, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 22, 2024

Landed in 4a54a80

@targos targos mentioned this pull request May 22, 2024
Merged
@Mortiemi

This comment was marked as off-topic.

Sign in to view
@aduh95 aduh95 deleted the sub-substr branch May 22, 2024 13:17
targos added a commit that referenced this pull request Jun 1, 2024
@aduh95 @targos
test: replace .substr with .slice
494fa54 
`String.prototype.substr` is deprecated, and using it will raise an
error when using ESLint 9+.

Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
PR-URL: #53070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@aduh95 @targos @sophoniie
test: replace .substr with .slice
2ef75cf 
`String.prototype.substr` is deprecated, and using it will raise an
error when using ESLint 9+.

Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
PR-URL: nodejs#53070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@aduh95 @targos @bmeck
test: replace .substr with .slice
22eb1fc 
`String.prototype.substr` is deprecated, and using it will raise an
error when using ESLint 9+.

Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
PR-URL: nodejs#53070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@aduh95 @targos @marco-ippolito
test: replace .substr with .slice
bddc182 
`String.prototype.substr` is deprecated, and using it will raise an
error when using ESLint 9+.

Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
PR-URL: #53070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@aduh95 @targos @marco-ippolito
test: replace .substr with .slice
8653d92 
`String.prototype.substr` is deprecated, and using it will raise an
error when using ESLint 9+.

Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
PR-URL: #53070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

@MoLow MoLow MoLow approved these changes

@trivikr trivikr trivikr approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.