Review requested:

• @nodejs/test_runner

Do we have tests for this so we validate how it actually affects the output?

This should probably have a test case with an actual and expected that both share an object - like:
const o = { o: true }; const actual = { o }, expected = { o }

I have looked a bit around and it would seem that a test would go somewhere around here:

But I actually don't understand that existing test and I'm also a bit unsure about how to run the test using the binary I built at out/Release/node.

I tried using --test test/parallel/test-runner-output.mjs but this just gave a bunch of strange-looking errors.

But I actually don't understand that existing test and I'm also a bit unsure about how to run the test using the binary I built at out/Release/node.

You can run it with the following command: python tools/test.py test/parallel/test-runner-output.mjs

Here's a test for this:

index f37d349503..95512e745f 100644
--- a/test/fixtures/test-runner/output/output.js
+++ b/test/fixtures/test-runner/output/output.js
@@ -382,8 +382,9 @@ test('assertion errors display actual and expected properly', async () => {
   circular.c = circular;
   const tmpLimit = Error.stackTraceLimit;
   Error.stackTraceLimit = 1;
+  const boo = [1];
   try {
-    assert.deepEqual({ foo: 1, bar: 1 }, circular); // eslint-disable-line no-restricted-properties
+    assert.deepEqual({ foo: 1, bar: 1, boo }, { boo, circular }); // eslint-disable-line no-restricted-properties
   } catch (err) {
     Error.stackTraceLimit = tmpLimit;
     throw err;

@aduh95 do you know what's the command that generates an updated snapshot file? I have tried --snapshot -j1 but the output is different.

@malthe if you can't find the command in the error output, you can always update the snapshot manually.

do you know what's the command that generates an updated snapshot file? I have tried --snapshot -j1 but the output is different.

try NODE_REGENERATE_SNAPSHOTS=1 ./node test/parallel/test-runner-output.mjs

Test added (squashed with first commit).

thanks for fixing this! can you amend the first commit message?

@MoLow squashed/amended now thanks.

bump

CI: https://ci.nodejs.org/job/node-test-pull-request/57452/

@MoLow not sure what these build failures are – they seem unrelated.

CI: https://ci.nodejs.org/job/node-test-pull-request/57471/

CI: https://ci.nodejs.org/job/node-test-pull-request/57483/

commits squashed

@malthe can you also rebase ontop upstream/main?

@MoLow rebased

CI: https://ci.nodejs.org/job/node-test-pull-request/57489/

CI: https://ci.nodejs.org/job/node-test-pull-request/57496/

Landed in 3ef7117