test: log more information in SEA tests#50759
Closed
joyeecheung wants to merge 2 commits intonodejs:mainfrom
Closed
test: log more information in SEA tests#50759joyeecheung wants to merge 2 commits intonodejs:mainfrom
joyeecheung wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
Collaborator
joyeecheung
changed the title
github-actions
bot
removed
the
request-ci
Collaborator
anonrig
approved these changes
Nov 16, 2023
Collaborator
anonrig
added
fast-track
Contributor
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
RaisinTen
reviewed
Nov 18, 2023
jasnell
approved these changes
Nov 19, 2023
aymen94
approved these changes
Nov 20, 2023
- Use spawnSyncAndExitWithoutError to log more information on error. - Use NODE_DEBUG_NATIVE to log internals - Skip the test when available disk space < 120MB
github-actions
bot
removed
the
request-ci
Collaborator
RaisinTen
approved these changes
Nov 21, 2023
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ef5c8e4...a3ee187 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
- Use spawnSyncAndExitWithoutError to log more information on error. - Use NODE_DEBUG_NATIVE to log internals - Skip the test when available disk space < 120MB PR-URL: #50759 Refs: #50740 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 4, 2023
- Use spawnSyncAndExitWithoutError to log more information on error. - Use NODE_DEBUG_NATIVE to log internals - Skip the test when available disk space < 120MB PR-URL: #50759 Refs: #50740 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
- Use spawnSyncAndExitWithoutError to log more information on error. - Use NODE_DEBUG_NATIVE to log internals - Skip the test when available disk space < 120MB PR-URL: #50759 Refs: #50740 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #50740