Conversation
marco-ippolito
left a comment
There was a problem hiding this comment.
it's not updating the maintaining-dependencies file, will be fixed by #50473
Commit Queue failed- Loading data for nodejs/node/pull/50457 ✔ Done loading data for nodejs/node/pull/50457 ----------------------------------- PR info ------------------------------------ Title deps: update acorn-walk to 8.3.1 (#50457) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-acorn-walk -> nodejs:main Labels author ready, needs-ci, dependencies Commits 2 - deps: update acorn-walk to 8.3.0 - deps: update acorn-walk to 8.3.1 Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/50457 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50457 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 29 Oct 2023 00:24:00 GMT ✔ Approvals: 4 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/50457#pullrequestreview-1702896182 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50457#pullrequestreview-1702897731 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50457#pullrequestreview-1702898751 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50457#pullrequestreview-1774150048 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-11T01:22:41Z: https://ci.nodejs.org/job/node-test-pull-request/56217/ - Querying data for job/node-test-pull-request/56217/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50457 From https://github.com/nodejs/node * branch refs/pull/50457/merge -> FETCH_HEAD ✔ Fetched commits as 898149fed817..6748938b59ca -------------------------------------------------------------------------------- [main 8afff8cf49] deps: update acorn-walk to 8.3.0 Date: Sun Oct 29 00:23:58 2023 +0000 6 files changed, 349 insertions(+), 119 deletions(-) create mode 100644 deps/acorn/acorn-walk/dist/walk.d.mts [main e03260786c] deps: update acorn-walk to 8.3.1 Date: Sun Dec 10 00:26:41 2023 +0000 6 files changed, 25 insertions(+), 13 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7260369417 |
|
Landed in 7014eac...14e3444 |
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This is an automated update of acorn-walk to 8.3.1.